Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No BOM for serialized output #54

Open
wants to merge 5 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@jbogard
Copy link

jbogard commented Mar 28, 2019

Changing default setting of encoding to not include the BOM for UTF8 per JSON RFC spec. Fixes #53

@jbogard

This comment has been minimized.

Copy link
Author

jbogard commented Apr 9, 2019

Thoughts?

@HEskandari

This comment has been minimized.

Copy link
Member

HEskandari commented Apr 10, 2019

@jbogard Thanks for the PR. We're still working on testing backwards and wire compatibility tests. We'll merge it once that's done.

Show resolved Hide resolved src/Tests/No_UTF8_BOM.cs Outdated
Show resolved Hide resolved src/Tests/No_UTF8_BOM.cs Outdated
Show resolved Hide resolved src/Tests/With_UTF8_BOM.cs Outdated
Show resolved Hide resolved src/Tests/With_UTF8_BOM.cs Outdated
Show resolved Hide resolved src/Tests/With_UTF8_BOM.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.