Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to document that document store is resolved during the configuration phase #443

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@andreasohlund
Copy link
Member

andreasohlund commented Oct 30, 2019

This PR documents that the persister resolves the IDocumentStore provided by the user during configuration. This breaks users on IServiceCollection or ones using immutable containers should they want to resolve the document store from their container

@andreasohlund andreasohlund merged commit 766b2f7 into master Nov 6, 2019
7 checks passed
7 checks passed
Compile Finished TeamCity Build NServiceBus / Persistence / NServiceBus.RavenDB / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Persistence / NServiceBus.RavenDB / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Persistence / NServiceBus.RavenDB / 3.3 Test (.NET Core on Linux) : Tests passed: 204, ignored: 18
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Persistence / NServiceBus.RavenDB / 3.2 Test (.NET Core on Windows) : Tests passed: 204, ignored: 18
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Persistence / NServiceBus.RavenDB / 3.1 Test (.NET Framework on Windows) : Tests passed: 205, ignore…
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@andreasohlund andreasohlund deleted the docstore-is-resolved-to-early branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.