Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Microsoft.Data.SqlClient and System.Data.SqClient #543

Merged
merged 37 commits into from Jan 29, 2020
Merged

Conversation

@danielmarbach
Copy link
Member

danielmarbach commented Jan 24, 2020

  • Bumps the major version to 6.0
  • Drops .NET Framework 4.5.2 support in favour of .NET Framework 4.6.1
  • Introduces NServiceBus.Transport.SqlServer version 6.0 that references Microsoft.Data.SqlClient
  • NServiceBus.SqlServer still references System.Data.SqlClient for smooth transition over period of time
  • Aligns the namespace from NServiceBus.Transport.SQLServer to NServiceBus.Transport.SqlServer
  • Removes obsoleted types
danielmarbach and others added 17 commits Jan 24, 2020
@bording bording force-pushed the namespace branch from 8cbc5f5 to 4bb9e85 Jan 24, 2020
@danielmarbach danielmarbach changed the title WIP Moving things Support for Microsoft.Data.SqlClient and System.Data.SqClient Jan 28, 2020
@danielmarbach danielmarbach added this to the 6.0.0 milestone Jan 28, 2020
@danielmarbach danielmarbach requested a review from bording Jan 28, 2020
danielmarbach and others added 6 commits Jan 28, 2020
…on key in a backward compatible way instead of using the type overload
@bording bording force-pushed the namespace branch from 3e9d738 to e26a27b Jan 29, 2020
Copy link
Member

bording left a comment

Looks good so far. We can merge this now and make any remaining changes (if any) in a followup PR.

@bording bording dismissed their stale review Jan 29, 2020

Going to remove unneeded cleanup changes

@danielmarbach danielmarbach force-pushed the namespace branch from 5eee4d5 to 07319eb Jan 29, 2020
@danielmarbach danielmarbach force-pushed the namespace branch from 07319eb to 7dd67af Jan 29, 2020
@bording bording merged commit eedc927 into master Jan 29, 2020
7 checks passed
7 checks passed
Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.3 Test (.NET Core on Linux) : Tests passed: 252, ignored: 49
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.2 Tests (.NET Core on Windows) : Tests passed: 252, ignored: 49
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.1 Test (.NET Framework on Windows) : Tests passed: 585, ignor…
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@bording bording deleted the namespace branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.