Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout Manager Compatibility Mode is disabled by default #544

Merged
merged 6 commits into from Jan 31, 2020

Conversation

@bording
Copy link
Member

bording commented Jan 30, 2020

This PR makes the timeout manager migration mode disabled by default.

The DisableTimeoutManagerCompatibility API has been marked with an obsolete and an EnableTimeoutManagerCompatibility API has been added instead.

I also changed how the DelayedDeliverySettings class stores its settings internally, which allowed for some simplication in the code. For example, the transport no longer needs to worry about when it is okay to set the TimeoutManagerMigrationMode setting.

It also appears that the When_configuring_delayed_delivery.cs file was still around despite the warning it was testing for being previously removed. Turns out these tests were being ignored because they were incorrectly marked with Requires.MessageDrivenPubSub().

bording added 4 commits Jan 30, 2020
@bording bording requested a review from danielmarbach Jan 30, 2020
bording and others added 2 commits Jan 30, 2020
@danielmarbach danielmarbach added this to the 6.0.0 milestone Jan 31, 2020
@danielmarbach danielmarbach merged commit 4dd4fc8 into master Jan 31, 2020
7 checks passed
7 checks passed
Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.3 Test (.NET Core on Linux) : Tests passed: 252, ignored: 45
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.2 Tests (.NET Core on Windows) : Tests passed: 252, ignored: 45
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.SqlServer / 3.1 Test (.NET Framework on Windows) : Tests passed: 585, ignor…
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@danielmarbach danielmarbach deleted the opt-in-timeout-manager branch Jan 31, 2020
@danielmarbach danielmarbach changed the title Make timeout manager compatibility opt-in Timeout Manager Compatibility Mode is disabled by default and requires an opt-in Feb 5, 2020
@danielmarbach danielmarbach changed the title Timeout Manager Compatibility Mode is disabled by default and requires an opt-in Timeout Manager Compatibility Mode is disabled by default Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.