Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept the token credential and fully qualified namespace as separate arguments instead of in a connection string #658

Merged
merged 2 commits into from Oct 28, 2022
Merged

Accept the token credential and fully qualified namespace as separate arguments instead of in a connection string #658

merged 2 commits into from Oct 28, 2022

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Oct 28, 2022 •
edited by ramonsmits

@danielmarbach danielmarbach mentioned this pull request Oct 28, 2022
Closed
@danielmarbach danielmarbach changed the title Make the token credential and the fullyQualifiedNamespace a dedicated connection setting instead of abusing the connection string. Make the token credential and the fullyQualifiedNamespace a dedicated connection setting instead of misusing the connection string. Oct 28, 2022
danielmarbach and others added 2 commits October 28, 2022 22:15
@danielmarbach
Make the token credential and the fullyQualifiedNamespace a dedicated…
597aa81 
… connection setting instead of abusing the connection string.
@danielmarbach @bording
Update src/Transport/AzureServiceBusTransportSettingsExtensions.cs
c0fe394 
Co-authored-by: Brandon Ording <bording@gmail.com>
@danielmarbach danielmarbach enabled auto-merge (squash) October 28, 2022 20:16
@danielmarbach danielmarbach merged commit ae84af1 into master Oct 28, 2022
@danielmarbach danielmarbach deleted the token-credential branch October 28, 2022 20:33
danielmarbach added a commit that referenced this pull request Nov 2, 2022
@danielmarbach
Make the token credential and the fullyQualifiedNamespace a dedicated…
9831719 
… connection setting instead of misusing the connection string. (#658)

* Make the token credential and the fullyQualifiedNamespace a dedicated connection setting instead of abusing the connection string.

* Update src/Transport/AzureServiceBusTransportSettingsExtensions.cs

Co-authored-by: Brandon Ording <bording@gmail.com>

Co-authored-by: Brandon Ording <bording@gmail.com>
# Conflicts:
#	src/Transport/AzureServiceBusTransport.cs
@danielmarbach danielmarbach mentioned this pull request Nov 11, 2022
Merged
3 tasks
@danielmarbach danielmarbach added this to the 3.0.0-rc.3 milestone Nov 11, 2022
@danielmarbach danielmarbach changed the title Make the token credential and the fullyQualifiedNamespace a dedicated connection setting instead of misusing the connection string. Expose the token credential and the fully qualified namespace as a dedicated connection setting instead of the connection string Nov 17, 2022
@adamralph adamralph changed the title Expose the token credential and the fully qualified namespace as a dedicated connection setting instead of the connection string Expose the token credential and the fully qualified namespace as a dedicated connection setting instead of the connection string Nov 17, 2022
@danielmarbach danielmarbach changed the title Expose the token credential and the fully qualified namespace as a dedicated connection setting instead of the connection string Accept the token credential and fully qualified namespace as separate arguments instead of in a connection string Nov 17, 2022
@danielmarbach danielmarbach mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bording bording bording approved these changes

@lailabougria lailabougria Awaiting requested review from lailabougria

@abparticular abparticular Awaiting requested review from abparticular

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.0.0-rc.3
Development

Successfully merging this pull request may close these issues.

When using TokenCredential validate if connection string only contains the fully qualified namespace
2 participants
@danielmarbach @bording