Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create rules via scripting #68

Merged
merged 7 commits into from Jul 31, 2019

Conversation

@danielmarbach
Copy link
Member

commented Jul 4, 2019

@danielmarbach danielmarbach requested review from SeanFeldman and bording and removed request for SeanFeldman Jul 4, 2019

@SeanFeldman
Copy link
Contributor

left a comment

I'm on a fence with multiple rules. If failure is taking place, it's really hard to know what failed without doing some investigation rather than trivial work.

src/CommandLine/Endpoint.cs Outdated Show resolved Hide resolved
src/CommandLine/Program.cs Outdated Show resolved Hide resolved
@bording
Copy link
Member

left a comment

While I like the idea of exposing a way to manage subscriptions, I don't think this is the right way to do it.

Instead of adding this to the endpoint create command, there should be endpoint subscribe and endpoint unsubscribe commands that can be invoked. These should take a single message type to subscribe to, since it's easy enough to script multiple calls if there are multiple subscriptions.

@danielmarbach danielmarbach force-pushed the global-tool-rule branch 2 times, most recently from 7f7938d to 16fbe3e Jul 29, 2019

@danielmarbach

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

@SeanFeldman @bording I switched to Brandon's suggestion. That also addresses the review comments from Sean.

@danielmarbach

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

Update the doco to reflect those changes

bording added some commits Jul 29, 2019

@bording
Copy link
Member

left a comment

Looking good, just have the remaining question about the rule delete exception.

I did do a formatting and text tweaking pass.

src/CommandLine/Endpoint.cs Outdated Show resolved Hide resolved

danielmarbach added some commits Jul 30, 2019

@danielmarbach danielmarbach requested a review from bording Jul 30, 2019

@danielmarbach danielmarbach merged commit 71a3cb0 into master Jul 31, 2019

7 checks passed

Compile Finished TeamCity Build NServiceBus / Transports / NServiceBus.Transport.AzureServiceBus / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Transports / NServiceBus.Transport.AzureServiceBus / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Transports / NServiceBus.Transport.AzureServiceBus / 3.3 Test (.NET Core on Linux) : Tests passed: 1…
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.Transport.AzureServiceBus / 3.2 Test (.NET Core on Windows) : Tests passed:…
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Transports / NServiceBus.Transport.AzureServiceBus / 3.1 Test (.NET Framework on Windows) : Tests pa…
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@danielmarbach danielmarbach deleted the global-tool-rule branch Jul 31, 2019

@danielmarbach danielmarbach changed the title Allow rule creation Ability to create rules via scripting Jul 31, 2019

@danielmarbach danielmarbach added this to the 1.1.3 milestone Jul 31, 2019

@danielmarbach danielmarbach restored the global-tool-rule branch Jul 31, 2019

@danielmarbach danielmarbach removed this from the 1.1.3 milestone Jul 31, 2019

@danielmarbach danielmarbach deleted the global-tool-rule branch Jul 31, 2019

@danielmarbach danielmarbach added this to the 1.2.0 milestone Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.