New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default isolation level for endpoints ReadCommitted #656

Closed
andreasohlund opened this Issue Sep 19, 2012 · 6 comments

Comments

Projects
None yet
4 participants
@andreasohlund
Member

andreasohlund commented Sep 19, 2012

The .net TransactionScope will default to Serializable which is not a suitable default for production use

@udidahan

This comment has been minimized.

Show comment
Hide comment
@udidahan

udidahan Sep 19, 2012

Member

Thinking again about this, I'm not sure it's worth confusing our users since our current default is repeatable read and the benefits of the change probably aren't that great.

Member

udidahan commented Sep 19, 2012

Thinking again about this, I'm not sure it's worth confusing our users since our current default is repeatable read and the benefits of the change probably aren't that great.

@andreasohlund

This comment has been minimized.

Show comment
Hide comment
@andreasohlund

andreasohlund Sep 19, 2012

Member

John checked and the default in 3.X is Serializable? (or am I missing
something?)

On Wed, Sep 19, 2012 at 9:52 AM, Udi Dahan notifications@github.com wrote:

Thinking again about this, I'm not sure it's worth confusing our users
since our current default is repeatable read and the benefits of the change
probably aren't that great.


Reply to this email directly or view it on GitHubhttps://github.com//issues/656#issuecomment-8684651.

http://andreasohlund.net
http://twitter.com/andreasohlund

Member

andreasohlund commented Sep 19, 2012

John checked and the default in 3.X is Serializable? (or am I missing
something?)

On Wed, Sep 19, 2012 at 9:52 AM, Udi Dahan notifications@github.com wrote:

Thinking again about this, I'm not sure it's worth confusing our users
since our current default is repeatable read and the benefits of the change
probably aren't that great.


Reply to this email directly or view it on GitHubhttps://github.com//issues/656#issuecomment-8684651.

http://andreasohlund.net
http://twitter.com/andreasohlund

@andreasohlund

This comment has been minimized.

Show comment
Hide comment
@andreasohlund

andreasohlund Sep 19, 2012

Member

Console.WriteLine(System.Transactions.Transaction.Current.IsolationLevel.ToString());

== "Serializable"

On Wed, Sep 19, 2012 at 9:58 AM, Andreas Öhlund andreasohlund2@gmail.comwrote:

John checked and the default in 3.X is Serializable? (or am I missing
something?)

On Wed, Sep 19, 2012 at 9:52 AM, Udi Dahan notifications@github.comwrote:

Thinking again about this, I'm not sure it's worth confusing our users
since our current default is repeatable read and the benefits of the change
probably aren't that great.


Reply to this email directly or view it on GitHubhttps://github.com//issues/656#issuecomment-8684651.

http://andreasohlund.net
http://twitter.com/andreasohlund

http://andreasohlund.net
http://twitter.com/andreasohlund

Member

andreasohlund commented Sep 19, 2012

Console.WriteLine(System.Transactions.Transaction.Current.IsolationLevel.ToString());

== "Serializable"

On Wed, Sep 19, 2012 at 9:58 AM, Andreas Öhlund andreasohlund2@gmail.comwrote:

John checked and the default in 3.X is Serializable? (or am I missing
something?)

On Wed, Sep 19, 2012 at 9:52 AM, Udi Dahan notifications@github.comwrote:

Thinking again about this, I'm not sure it's worth confusing our users
since our current default is repeatable read and the benefits of the change
probably aren't that great.


Reply to this email directly or view it on GitHubhttps://github.com//issues/656#issuecomment-8684651.

http://andreasohlund.net
http://twitter.com/andreasohlund

http://andreasohlund.net
http://twitter.com/andreasohlund

@ghost ghost assigned shlomii Sep 26, 2012

@chrisbednarski

This comment has been minimized.

Show comment
Hide comment
@chrisbednarski

chrisbednarski Nov 6, 2012

Contributor

Won't defaulting to a lower level isolation level introduce potential for data inconsistencies within an endpoint that is running multiple worker threads? (as indicated @ http://www.udidahan.com/2011/09/18/inconsistent-data-poor-performance-or-soa-pick-one/)

Contributor

chrisbednarski commented Nov 6, 2012

Won't defaulting to a lower level isolation level introduce potential for data inconsistencies within an endpoint that is running multiple worker threads? (as indicated @ http://www.udidahan.com/2011/09/18/inconsistent-data-poor-performance-or-soa-pick-one/)

@andreasohlund

This comment has been minimized.

Show comment
Hide comment
@andreasohlund

andreasohlund Nov 11, 2012

Member

Yes, but given that the sagas and all the other "storages" has been designed to be used with ReadCommited I think that this is a more sensible default

Member

andreasohlund commented Nov 11, 2012

Yes, but given that the sagas and all the other "storages" has been designed to be used with ReadCommited I think that this is a more sensible default

@andreasohlund

This comment has been minimized.

Show comment
Hide comment
@andreasohlund
Member

andreasohlund commented Nov 11, 2012

Fixed in 2becebe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment