Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MessageId on DelayedRetryMessage #5401

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@danielmarbach
Copy link
Member

commented Jul 2, 2019

Based on https://discuss.particular.net/t/faults-delayedretrymessage/1244

Seemed like a low hanging fruit.

I currently went for obsolete with warn of the existing constructor. Happy to discuss the pros and cons

@danielmarbach danielmarbach requested a review from timbussmann Jul 2, 2019

@timbussmann timbussmann merged commit 728b86f into develop Jul 2, 2019

7 checks passed

Compile Finished TeamCity Build NServiceBus / Core / 1. Compile : Running
Details
Inspections Finished TeamCity Build NServiceBus / Core / 2. Inspections : Running
Details
Test .NET Core on Linux Finished TeamCity Build NServiceBus / Core / 3.3 Test (.NET Core on Linux) : Tests passed: 1170, ignored: 46
Details
Test .NET Core on Windows Finished TeamCity Build NServiceBus / Core / 3.2 Test (.NET Core on Windows) : Tests passed: 1170, ignored: 46
Details
Test .NET Framework on Windows Finished TeamCity Build NServiceBus / Core / 3.1 Test (Framework on Windows) : Tests passed: 1409, ignored: 100
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@timbussmann timbussmann deleted the messageid-errornotifications branch Jul 2, 2019

@timbussmann timbussmann added this to the 7.2.0 milestone Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.