New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AmazonSQS Transport : Retries don't work #1433
Comments
I think the problem is here
|
Correct AmazonSQS is case sensitive. Really weird that our acceptance tests didn't catch that one. We'll have to do a closer investigation, especially because we have tests that do retry and they are green in our CI environment. Otherwise, we wouldn't have released this functionality Thanks for reporting |
@AbdoHassanUMG Can you explain why you think retries don't work? The queue we are talking about is |
Without handling the case-sensitivity I get the following error at SC console when attempting a "retry" 2018-09-26 13:01:25.7133|93|Info|ServiceControl.Recoverability.RetryProcessor|Forwarding batch RetryBatches/935223a9-4c7a-4457-b88c-76fc19a965bb with 1 messages
|
Ah ok! That makes sense. We recently changed the behavior of the raw factory to no longer auto-create queues and that's why it is now broken. Smells like a patch to me. Thoughts @Particular/servicecontrol-maintainers ? |
Fix for AmazonSQS Transport : Retries don't work #1433
Fixed as part of #1434. Thanks @AbdoHassanUMG for the contribution! |
Thanks @danielmarbach |
Soonish ;) Latest Monday I think |
Thanks Daniel ! |
@AbdoHassanUMG it is out https://github.com/Particular/ServiceControl/releases/tag/3.2.0 Thank you so much for your patience and contributions! |
@danielmarbach Thanks a lot for turning this arranging this release quickly. |
Sorry we had a few hick ups with the build pipeline
https://github.com/Particular/ServiceControl/releases
|
Message Replay doesn't work when using AmazonSQS transport because of inconsistency in the casing of Error Queue. It is called "{InstanceName}.Errors" when writing the error message and "{InstanceName}.errors" when forwarding it.
This should cause no problem if tested using MSMQ but causes trouble in SQS because queue names are case-sensitive.
I have created a fix for this and I want to send it as a pull request
The text was updated successfully, but these errors were encountered: