New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceControl with RabbitMQ cannot log exceptions due to missing library #1502

Closed
boblangley opened this Issue Nov 27, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@boblangley
Copy link
Member

boblangley commented Nov 27, 2018

The RabbitMQ client has a dependency on Microsoft.Diagnostics.Tracing.EventSource.Redist which is not being packaged in the 3.x branch. This is probably a new dependency of the transport from the move to core v7.

The packaging project does not include it: https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControlInstaller.Packaging/ServiceControlInstaller.Packaging.csproj#L57-L59

When this is not included it can result in RabbitMq being unable to properly raise/log exceptions:

Exception Info: System.IO.FileNotFoundException
at RabbitMQ.Client.ESLog.Error(System.String, System.Exception)
at RabbitMQ.Client.Framing.Impl.Connection.LogCloseError(System.String, System.Exception)
at RabbitMQ.Client.Framing.Impl.Connection.MainLoop()
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
at System.Threading.ThreadHelper.ThreadStart()

@boblangley boblangley transferred this issue from another repository Nov 27, 2018

@andreasohlund

This comment has been minimized.

Copy link
Member

andreasohlund commented Nov 27, 2018

Just adding that the monitoring is packaging *.dll so it wouldn’t be effected

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Dec 6, 2018

Fixed in #1521

@SzymonPobiega SzymonPobiega changed the title ServiceControl 3x does not include all of the RabbitMQ dependencies ServiceControl does not include all of the RabbitMQ dependencies preventing it from raising and logging exceptions Dec 6, 2018

@SzymonPobiega SzymonPobiega changed the title ServiceControl does not include all of the RabbitMQ dependencies preventing it from raising and logging exceptions ServiceControl with RabbitMQ cannot log exceptions due to missing library Dec 6, 2018

@SzymonPobiega SzymonPobiega added this to the 3.4.0 milestone Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment