Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of an exception message can cause failure in importing an error message into ServiceControl #1692

Closed
ramonsmits opened this issue Jun 21, 2019 · 0 comments

Comments

@ramonsmits
Copy link
Member

commented Jun 21, 2019

Message import can result in a RegexMatchTimeoutException due to very large exception message value containing an XMLfragment with exception stack trace.

The default timeout in the StackTraceParser is 5 seconds, after setting this to 30 seconds no timeout occurred but the operation took 16 seconds.

The workaround is to manually edit the "NServiceBus.ExceptionInfo.StackTrace" value to not contain the XML fragment but this isn't an option if a lot of messages are stored in RavenDB.

Import should not fail due to a timeout in the stacktrace parser but have an alternative flow.

Exception

System.Text.RegularExpressions.RegexMatchTimeoutException: The RegEx engine has timed out while trying to match a pattern to an input string. This can occur for many reasons, including very large inputs or excessive backtracking caused by nested quantifiers, back-references and other factors.
...
   at ServiceControl.Recoverability.ExceptionTypeAndStackTraceFailureClassifier.ClassifyFailure(ClassifiableMessageDetails failure)
...

@ramonsmits ramonsmits changed the title RegexMatchTimeoutException due to very large exception message value containing an xml fragment with exception stack trace RegexMatchTimeoutException in Stacktrace parser results in failed imports Jun 21, 2019

@SzymonPobiega SzymonPobiega added the Bug label Jul 26, 2019

@SzymonPobiega SzymonPobiega added this to the 3.8.3 milestone Jul 26, 2019

@SzymonPobiega SzymonPobiega changed the title RegexMatchTimeoutException in Stacktrace parser results in failed imports Contents of an exception message can cause failure in importing an error message into ServiceControl Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.