New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve License Expiry Experience #1436

Merged
merged 32 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@mikeminutillo
Copy link
Member

mikeminutillo commented Sep 26, 2018

Improves the user experience by having the UI clearly indicate in the ServiceControl management utility when the upgrade protection expires and what the user needs to do when it expires.

@mikeminutillo mikeminutillo requested a review from boblangley Nov 1, 2018

@mikeminutillo

This comment has been minimized.

Copy link
Member

mikeminutillo commented Nov 1, 2018

@boblangley the only outstanding thing is that some of the text messages may change

@boblangley
Copy link
Member

boblangley left a comment

Could the license component portion of this be moved to the Engine so we can unit test and eventually make the non wpf experience better as well? I am thinking the factory could use so basic tests and we might want some messaging in the powershell scripts.

yield return PlatformExpiryComponent(details.ExpirationDate.Value);
}

if (details.UpgradeProtectionExpiration.HasValue)

This comment has been minimized.

@boblangley

boblangley Nov 5, 2018

Member

Shouldn't this be before expiration date? All of the perpetual licenses I have seen have both.

This comment has been minimized.

@mikeminutillo

mikeminutillo Nov 6, 2018

Member

They have both in the file but we don't load expiration date for perpetual licenses

This comment has been minimized.

@mikeminutillo

mikeminutillo Nov 6, 2018

Member

And because these are doing a yield return, it won't short circuit anyway. If your license reports having both, we will display both.

@mikeminutillo

This comment has been minimized.

Copy link
Member

mikeminutillo commented Nov 6, 2018

Could the license component portion of this be moved to the Engine so we can unit test and eventually make the non wpf experience better as well? I am thinking the factory could use so basic tests and we might want some messaging in the powershell scripts.

I discussed this with @HEskandari and we both feel that the "logic" in these changes is really a UI concern. In SI, the change calculates days until expiry and then uses that to show/hide stuff. In SCMU, I convert the License into a dictionary of components and then bind the UI to that.

The only thing that maybe belongs in the licensing package is the calculation of days remaining.

@mikeminutillo mikeminutillo changed the title [WIP] Improve License Expiry Experience Improve License Expiry Experience Nov 7, 2018

@mikeminutillo

This comment has been minimized.

Copy link
Member

mikeminutillo commented Nov 7, 2018

@boblangley as SCMU is the only code to currently rely on the license component factory, can we skip extraction until someone else needs the code?

I can add some unit (approval) tests around them.

@boblangley

This comment has been minimized.

Copy link
Member

boblangley commented Nov 7, 2018

👍

mikeminutillo added some commits Nov 19, 2018

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Nov 20, 2018

@mikeminutillo is there anything here I can help with to merge this one?

@mikeminutillo

This comment has been minimized.

Copy link
Member

mikeminutillo commented Nov 21, 2018

@SzymonPobiega I have tested with a bunch of different licenses after the last round of changes. I am happy to merge and release.

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Nov 21, 2018

@mikeminutillo do we need to release it or would merging to develop be just fine?

@mikeminutillo

This comment has been minimized.

Copy link
Member

mikeminutillo commented Nov 21, 2018

@SzymonPobiega it can go in the next maintenance release.

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Nov 21, 2018

Cool. Then I am merging it 🎉

@SzymonPobiega SzymonPobiega merged commit da88ed3 into develop Nov 21, 2018

1 check passed

continuous-integration/teamcity Finished TeamCity Build ServiceControl :: 1. Build : Tests passed: 194, ignored: 8
Details

@SzymonPobiega SzymonPobiega deleted the improve-license-expiry branch Nov 21, 2018

@boblangley boblangley added this to the 3.4.0 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment