Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to specify S3 bucket for large messages in ServiceControl causes messages to be DLQed #1634

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@danielmarbach
Copy link
Member

commented May 1, 2019

Fixes #1616

Who's affected

Customer using AmazonSQS with messages with large bodies stored on S3

Symptoms

When failed messages with large message bodies stored in S3 are ingested the messages cannot be retried due to the following exception

2019-04-01 12:45:13.0159|31|Warn|NServiceBus.Transports.SQS.MessagePump|Treating message with SQS Message Id 31407dd0-b5ee-4427-83c5-0cdf281dcf11 as a poison message due to exception Amazon.S3.AmazonS3Exception: The specified bucket does not exist ---> Amazon.Runtime.Internal.HttpErrorResponseException: The remote server returned an error: (404) Not Found. ---> System.Net.WebException: The remote server returned an error: (404) Not Found.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.HttpRequest.<GetResponseAsync>d__16.MoveNext()
   --- End of inner exception stack trace ---

@danielmarbach danielmarbach changed the title WIP Abilit to specify S3 bucket in connection string WIP Ability to specify S3 bucket in connection string May 1, 2019

@danielmarbach danielmarbach requested a review from andreasohlund May 1, 2019

@mikeminutillo
Copy link
Member

left a comment

My only note is that the log messages for loading from environment variables could be moved to the end and combined. There's no way to get one log message without also getting the other. It's minor though and probably not worth the change.

@danielmarbach danielmarbach changed the title WIP Ability to specify S3 bucket in connection string Ability to specify S3 bucket in connection string May 2, 2019

@danielmarbach danielmarbach merged commit fe9ab83 into hotfix-3.7.1 May 2, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/teamcity Finished TeamCity Build ServiceControl / 1. Build : Tests passed: 198, ignored: 8
Details

@danielmarbach danielmarbach deleted the sqs-bucket branch May 2, 2019

@danielmarbach danielmarbach changed the title Ability to specify S3 bucket in connection string Inability to specify S3 bucket for large messages in ServiceControl causes messages to be DLQed May 3, 2019

@danielmarbach danielmarbach added this to the 3.7.1 milestone May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.