Ensure RetryAcknowledgementBehavior gets triggered #5149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
force-pushed
the
ResolvedByEdit
branch
2 times, most recently
from
cec3fad to
7ebe491
Compare
| } | ||
|
|
||
| public Task Announce(MessageContext messageContext) | ||
| public Task Announce(string failedMessageId) |
There was a problem hiding this comment.
This change creates a difference between this Announce and ErrorProcessor.Announce. I know that the latter uses much more information - would it be worth to keep these both consistent?
....AcceptanceTests/Recoverability/ExternalIntegration/When_a_failed_msg_is_resolved_by_edit.cs
Show resolved
Hide resolved
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
12 times, most recently
from
07c743e to
0c3d770
Compare
bartekwasielak
force-pushed
the
ResolvedByEdit
branch
3 times, most recently
from
c9c8baa to
b47687e
Compare
cquirosj
force-pushed
the
ResolvedByEdit
branch
from
b47687e to
0e7e1f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5118
RetryAcknowledgementBehavior in NSB core expects a value in both "ServiceControl.Retry.UniqueMessageId" and "ServiceControl.Retry.AcknowledgementQueue" headers in order to dispatch an OutgoingMessage confirming the successful retry