Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization of a message starting multiple Sagas in the Flow Diagram #230

Closed
joj opened this issue Feb 6, 2014 · 15 comments

Comments

Projects
None yet
8 participants
@joj
Copy link
Contributor

commented Feb 6, 2014

In the Message Flow diagram when the message starts more than one saga, the message node should correctly visualize all the Sagas.

For example, the message starting two sagas should look like this:

Screen Shot 2019-05-29 at 12 58 27 pm

@joj joj self-assigned this Feb 6, 2014

@dannycohen

This comment has been minimized.

Copy link

commented Feb 6, 2014

In Saga, implement some way to switch between Sagas.

For now, switching between Sagas will be through the message links in Message Flow, and later through Sequence Diagram as well.

Service Control, that means modifying Status to work like Invoked Sagas

Not sure I understand what you mean.

You are raising a good point of whether / how we allow searching for and navigating between Sagas.
Not sure what the usage scenario of that will be: Sagas a driven by message processing / timeouts etc, and have no real "name" aside from their SagaId and Type, and both are searchable from the standard search.
Thoughts ?
A

@joj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2014

I added Saga Status (the little completed/update icon in the flow) as a header in Service Control, but ATM it's working as if there was only one saga. It worked for what I needed to do, but it should allow for multiple sagas.

On the navigation part, I find it inconsistent to switch to the Saga tab (manually, clicking the tab) and not know in which of the related sagas you are. That's why I think we need some sort of "this is the saga name, these are the available sagas" thing. Probably as a drop down next to Toggle Endpoint, but I'd like @sergioc to chime in on that.

@joj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2014

BTW, the interface in SI is also expecting only one Saga right now. That's the reason for the issue :)

@sergioc

This comment has been minimized.

Copy link

commented Feb 6, 2014

AFAIK we were only supporting one saga view. @dannycohen comments?

@dannycohen

This comment has been minimized.

Copy link

commented Feb 6, 2014

@joaquinjares -

The drop down option is an interesting one, but there's also the link back to the message at the top of the Saga View.

I think we should experiment a bit with the UI and see how it feels with multiple Sagas per message, and then decide.

We'll review the Saga implementation with @udidahan, @indualagarsamy and @sergioc next week and raise this issue.

Regarding:

I added Saga Status (the little completed/update icon in the flow) as a header in Service Control, but ATM it's working as if there was only one saga. It worked for what I needed to do, but it should allow for multiple sagas.

Please raise a bug in SC on this limitation. Lets discuss with @johnsimons and team.

@sergioc -

some clarifications below:

A message can have multiple Sagas associated with it (i.e. invoked during the message's processing)

  • Currently we only support a single Saga View, that is accessible (linkable) from the message (in the Message Flow now, and Sequence diagram in the future)
  • The message contains the links to all the Sagas invoked during its processing
  • One Saga is displayed at a time, by clicking on the link to it from the message
  • A Saga has an Id (guid) and a Type that are searchable, and through the messages returned, you can select+view the saga associated with the messages
    • Note: Saga timeout messages are messages and appear in search results and in the message list

// CC @udidahan, @indualagarsamy

@udidahan

This comment has been minimized.

Copy link
Member

commented Feb 6, 2014

This is not a priority for the v1 release.

@dannycohen

This comment has been minimized.

Copy link

commented Feb 6, 2014

@udidahan -

This is not a priority for the v1 release.

I agree regarding SI UI, but we need SC to support the multiple headers.

@joj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2014

After the latest change/pull in SC, implementing this in SI (except for the Saga tab, meaning items 1 and 3 in my initial description) is fairly trivial and should take a few minutes. Please @udidahan and @dannycohen confirm if you want to delay anyway for other reasons. Timing should not be a concern right now. We can implement the saga tab for multiple instances (item 2) later on.

@udidahan

This comment has been minimized.

Copy link
Member

commented Feb 10, 2014

I wouldn’t want to have to analyze whether what we’ve done is actually right for the v1 platform release. I’d feel much more comfortable dealing with it after the platform is already out.

@dannycohen

This comment has been minimized.

Copy link

commented Feb 10, 2014

@udidahan / @joaquinjares - We have a saga status review on Thu. Lets discuss in depth then.

@joj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2014

Ok

@johnsimons

This comment has been minimized.

Copy link
Contributor

commented May 21, 2015

@andreasohlund am I correct to say that for us to implement this in SI the core would have to change to collect the multiple sagaids and hence this is not supported ?

@andreasohlund

This comment has been minimized.

Copy link
Member

commented May 24, 2015

Pretty sure we can handle this in the saga audit plugin?

That said we only support 1 instance per saga type so the screenshot in the description is not correct

@johnsimons

This comment has been minimized.

Copy link
Contributor

commented May 24, 2015

@andreasohlund

Pretty sure we can handle this in the saga audit plugin?

Yes we could do that, but currently the message flow diagram has no dependency of the plugin, so that would be a change

That said we only support 1 instance per saga type so the screenshot in the description is not correct

Yes agree, but still highlights the issue

@johnsimons johnsimons self-assigned this May 24, 2015

@andreasohlund

This comment has been minimized.

Copy link
Member

commented May 25, 2015

Now I get it, you're talking about the SagaId, SagaType headers.

Setup a call when you're back fro YOW so we can hash it out. Think we need
to introduce a new header to fix this

On Mon, May 25, 2015 at 12:52 AM, John Simons notifications@github.com
wrote:

@andreasohlund https://github.com/andreasohlund

Pretty sure we can handle this in the saga audit plugin?

Yes we could do that, but currently the message flow diagram has no
dependency of the plugin, so that would be a change

That said we only support 1 instance per saga type so the screenshot in
the description is not correct

Yes agree, but still highlights the issue


Reply to this email directly or view it on GitHub
#230 (comment)
.

@johnsimons johnsimons removed their assignment Apr 2, 2016

@HEskandari HEskandari changed the title Implement support for multiple Sagas Visualization of a message starting multiple Sagas in the Flow Diagram May 30, 2019

@HEskandari HEskandari added this to the 1.13.0 milestone May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.