Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Invocation URIs only support fully qualified domain names or localhost #827

Closed
danielmarbach opened this issue Apr 9, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@danielmarbach
Copy link
Member

commented Apr 9, 2019

Who's affected

Customers using application invocations links like si://anyknownserver:33333/api and ServiceControl APIs being hosted under URIs like http://anyknownserver:33333/api

Symptoms

Because we use isolated storage for storing profiles it is difficult to use register multiple ServiceControl URIs in the profile settings. As a workaround, we suggest using

https://docs.particular.net/serviceinsight/application-invocation

In theory links like si://anyknownserver:3333/api for example should open ServiceInsight and connect to http://anyknownserver:3333/api

Unfortunately, there is an issue with this approach:

The regular expression used to validate the URI passed over the command line arguments enforces the usage of TLD, so links like http://anyknownserver:33333/api do not satisfy the regex but only fully qualified domain names would

Furthermore when the regex doesn't match SI silently falls back to ignore the URI and switches to use the recently used connection URI.

@HEskandari HEskandari added the Bug label Apr 9, 2019

HEskandari added a commit that referenced this issue May 23, 2019

HEskandari added a commit that referenced this issue May 23, 2019

@HEskandari HEskandari added this to the 1.13.0 milestone May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.