Allow unarchiving of more than 50 messages at a time

[sergioc]

Selecting more than 50 messages to unarchive caused all of them to be removed from the UI (as expected) but only the first 50 of them were actually unarchived without any warning or error. Refreshing the page would show the updated list again (without the 50 unarchived messages)

This was because of incorrect paging where the same 50 archived messages were retrieved over and over again whenever the user scrolled to the bottom.

Details of change

Fixed the paging so that we retrieve the correct results as users scroll

Original bug report

Feedback from @parto:

If you select more than 50 messages to unarchive, all of them are removed from the UI but only 50 of them are actually unarchived without any warning or error. If you refresh the page you still get failed archived messages in the list.

---

Technical information if reporting a bug:

• ServicePulse version: v1.14.4
• ServiceControl version: v3.0.1 / 3d24e07
• Browser version: Chrome Version 69.0

[sergioc]

@parto can you indicate which ServicePulse, ServiceControl versions did you use when you experienced this issue? And which browser version?

[parto]

ServiceControl v3.0.1 / 3d24e07
ServicePulse v1.14.4
Chrome Version 69.0

[kbaley]

Investigating this further, it seems like messages after the infinite scroll limit can sometimes get missed. I've been able to reproduce this intermittently by selecting ten messages at the front, scrolling enough to load more messages, then select more messages. In this case (again intermittently), only the first ten messages get archived.

[kbaley]

@indualagarsamy and I traced this to a bug in ServiceControl. The ServicePulse request is correct but it seems ServiceControl is retrieving only 50 items at a time. One solution would be to process each item one at a time like we do for failed messages.

Either way, it seems like this issue should be moved (or closed and a new one opened in Particular/ServiceControl).

[kbaley]

On further investigation, our initial assessment was wrong. There is a bug in the paging code that causes the same 50 messages to be retrieved every time you load more results. PR is up to fix.