Reformat with prettier and more eslint rules included #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This include == should be === More usages let/const
PhilBastian
approved these changes
Feb 6, 2024
| function parseObject(obj, propertiesToSkip, path) { | ||
| if (path == undefined) path = ""; | ||
| if (path === undefined) path = ""; |
Contributor
There was a problem hiding this comment.
should be comparing to == null rather than === undefined I would think?
Member
Author
There was a problem hiding this comment.
We are using the "smart" mode, and it seems to suggest ===.
@PhilBastian is the "smart" mode the wrong setting?
| '<div class="license-warning"><strong>Non-production development license expiring</strong><div>Your non-production development license will expire soon. To continue using the Particular Service Platform you\'ll need to extend your license.</div><a href="http://particular.net/extend-your-trial?p=servicepulse" class="btn btn-license-warning"><i class="fa fa-external-link-alt"></i> Extend your license</a><a href="#/configuration" class="btn btn-license-warning-light">View license details</a></div>'; | ||
|
|
||
| export var license = reactive({ | ||
| export let license = reactive({ |
Member
Author
There was a problem hiding this comment.
We reassign license later on.
Maybe we should not do that!
Member
Author
|
@PhilBastian I have reverted the svg changes and added prettier ignore to it |
johnsimons
force-pushed
the
john/coffee
branch
from
d114325 to
47f85c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I did a complete reformat again of the whole code, not many changes from it.
I fixed all the eslint rules that were set as warnings, eg prefer-const, triple equality.
Finally I enabled a few more eslint rules to do with imports.
So lots of files changed but mostly just code style updated.