Migrating more composables and a few vue files #1702
Conversation
| export async function useUnarchiveMessage(ids: string[]) { | ||
| const response = await usePatchToServiceControl("errors/unarchive/", ids); | ||
| if (!response.ok) { | ||
| throw response.statusText; |
There was a problem hiding this comment.
i think we should implement https://eslint.org/docs/latest/rules/no-throw-literal
There was a problem hiding this comment.
Added rule and updated code accordingly
There was a problem hiding this comment.
but you missed this line?
|
|
||
| //edit or create note by group id | ||
| export async function useEditOrCreateNote(groupId: string, comment: string) { | ||
| const response = await usePostToServiceControl(`recoverability/groups/${groupId}/comment?comment=${comment}`); |
There was a problem hiding this comment.
the following functions are identical except for the url, could extract...
There was a problem hiding this comment.
I have tidy this a little bit
| getRedirect(); | ||
| } else { | ||
| redirectSaveSuccessful.value = false; | ||
| if (result.status === "409" || result.status === 409) { |
There was a problem hiding this comment.
I'm guessing this is TypeScript telling us this can only be a number
There was a problem hiding this comment.
yes I typed the status to be a number
| try { | ||
| const response = await useArchiveMessage([id.value]); | ||
| if (response !== undefined) { | ||
| if (response.data.ok) { |
There was a problem hiding this comment.
This must be ok or we would have thrown, right?
There was a problem hiding this comment.
You are right @mikeminutillo.
I refactored the code to get rid of that, and also removed the catch->console.log while I was there.
No description provided.