-
Notifications
You must be signed in to change notification settings - Fork 26
Move API related functionality out of views to stores/clients #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
reviewed
Oct 28, 2025
# Conflicts: # src/Frontend/src/components/failedmessages/PendingRetries.vue
johnsimons
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1905
Summary
Refactor frontend state management by extracting API communication logic from Pinia stores into dedicated client modules, and consolidate related functionality into specialized stores.
Changes
RecoverabilityStorefor failed message operations andDeletedMessageGroupsStorefor managing deleted message groupsserviceControlClientandmonitoringClientto handle all ServiceControl and Monitoring API callsServiceControlStoreandEditRetryStoreas their functionality has been better organized elsewhereBenefits
All existing functionality remains intact with no changes to user-facing features.