Skip to content

Conversation

@PhilBastian
Copy link
Contributor

@PhilBastian PhilBastian commented Oct 28, 2025

This is part of #1905

Summary

Refactor frontend state management by extracting API communication logic from Pinia stores into dedicated client modules, and consolidate related functionality into specialized stores.

Changes

  • New stores: Created RecoverabilityStore for failed message operations and DeletedMessageGroupsStore for managing deleted message groups
  • New API clients: Extracted serviceControlClient and monitoringClient to handle all ServiceControl and Monitoring API calls
  • Removed stores: Eliminated ServiceControlStore and EditRetryStore as their functionality has been better organized elsewhere
  • Simplified components: Significantly reduced component complexity by moving business logic into stores:
    • DeletedMessageGroups.vue: 255 lines → 42 lines
    • DeletedMessages.vue, FailedMessages.vue, PendingRetries.vue etc. all significantly simplified
  • Improved auto-refresh: Enhanced the auto-refresh composable with better state tracking

Benefits

  • Better separation between API communication and state management
  • More reusable and testable code
  • Cleaner, more maintainable components
  • Improved organization of related functionality

All existing functionality remains intact with no changes to user-facing features.

@PhilBastian PhilBastian changed the title move monitoring relation functionality to monitoring store move API related functionality out of views to stores/clients Nov 28, 2025
@johnsimons johnsimons changed the title move API related functionality out of views to stores/clients Move API related functionality out of views to stores/clients Nov 28, 2025
@PhilBastian PhilBastian merged commit 0003bd4 into master Nov 28, 2025
5 checks passed
@PhilBastian PhilBastian deleted the monitoring_store branch November 28, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants