From 7b7a34ed818ddaaff0b96523e2324fc7ea76e297 Mon Sep 17 00:00:00 2001
From: WilliamBZA <william.brander@gmail.com>
Date: Wed, 30 May 2018 10:03:48 +0200
Subject: [PATCH] Stop using javascript://

---
 .../directives/ui.particular.redirectLink.tpl.html   |  4 ++--
 src/ServicePulse.Host/app/js/views/archive/view.html |  8 ++++----
 .../app/js/views/failed_groups/view.html             |  2 +-
 .../app/js/views/failed_messages/view.html           |  8 ++++----
 .../app/js/views/pending_retries/view.html           | 12 ++++++------
 5 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/ServicePulse.Host/app/js/directives/ui.particular.redirectLink.tpl.html b/src/ServicePulse.Host/app/js/directives/ui.particular.redirectLink.tpl.html
index 46456d05e3..9c6a11afec 100644
--- a/src/ServicePulse.Host/app/js/directives/ui.particular.redirectLink.tpl.html
+++ b/src/ServicePulse.Host/app/js/directives/ui.particular.redirectLink.tpl.html
@@ -1,10 +1,10 @@
 <span class="version-info">
     <span ng-hide="redirect">
         <i class="fa pa-redirect-source pa-redirect-small" uib-tooltip="Redirect"></i>
-        No redirect (<a href="javascript://" ng-click="createRedirect()">create</a>)
+        No redirect (<a href="#" ng-click="$event.preventDefault();createRedirect()">create</a>)
     </span>
     <span ng-show="redirect" uib-tooltip="{{redirect.to_physical_address}}">
         <i class="fa pa-redirect-source pa-redirect-small" uib-tooltip="Redirect"></i>
-        Redirect: {{redirect.to_physical_address}} (<a href="javascript://" ng-click="editRedirect(redirect)">modify</a>)
+        Redirect: {{redirect.to_physical_address}} (<a href="#" ng-click="$event.preventDefault();editRedirect(redirect)">modify</a>)
     </span>
 </span>
diff --git a/src/ServicePulse.Host/app/js/views/archive/view.html b/src/ServicePulse.Host/app/js/views/archive/view.html
index 08034add0c..285193b686 100644
--- a/src/ServicePulse.Host/app/js/views/archive/view.html
+++ b/src/ServicePulse.Host/app/js/views/archive/view.html
@@ -16,16 +16,16 @@
                         </button>
                         <ul class="dropdown-menu">
                             <li>
-                                <a href="javascript://" ng-click="vm.selectTimeGroup()"><span class="fa fa-calendar" aria-hidden="true"></span> All Archived</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup()"><span class="fa fa-calendar" aria-hidden="true"></span> All Archived</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectTimeGroup('2', 'hours')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 2 Hours</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('2', 'hours')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 2 Hours</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectTimeGroup('1', 'days')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 1 Day</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('1', 'days')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 1 Day</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectTimeGroup('7', 'days')"><span class="fa fa-calendar " aria-hidden="true"></span> Archived in the last 7 Days</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('7', 'days')"><span class="fa fa-calendar " aria-hidden="true"></span> Archived in the last 7 Days</a>
                             </li>
                         </ul>
                     </div>
diff --git a/src/ServicePulse.Host/app/js/views/failed_groups/view.html b/src/ServicePulse.Host/app/js/views/failed_groups/view.html
index bd977d7aa4..7a347f6f3f 100644
--- a/src/ServicePulse.Host/app/js/views/failed_groups/view.html
+++ b/src/ServicePulse.Host/app/js/views/failed_groups/view.html
@@ -57,7 +57,7 @@ <h6>Failed message groups</h6>
                     </button>
                     <ul class="dropdown-menu">
                         <li ng-repeat="classifier in vm.availableClassifiers">
-                            <a href="javascript://" ng-click="vm.selectClassification(classifier)">{{classifier}}</a>
+                            <a href="#" ng-click="$event.preventDefault();vm.selectClassification(classifier)">{{classifier}}</a>
                         </li>
                     </ul>
                 </div>
diff --git a/src/ServicePulse.Host/app/js/views/failed_messages/view.html b/src/ServicePulse.Host/app/js/views/failed_messages/view.html
index adc45b81b6..a5185c08f2 100644
--- a/src/ServicePulse.Host/app/js/views/failed_messages/view.html
+++ b/src/ServicePulse.Host/app/js/views/failed_messages/view.html
@@ -41,16 +41,16 @@ <h3 class="active group-title group-message-count">{{vm.selectedExceptionGroup.c
                         </button>
                         <ul class="dropdown-menu">
                             <li>
-                                <a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Message Type (ascending)</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Message Type (ascending)</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Message Type (descending)</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Message Type (descending)</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Time Of Failure (ascending)</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Time Of Failure (ascending)</a>
                             </li>
                             <li>
-                                <a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Time Of Failure (descending)</a>
+                                <a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Time Of Failure (descending)</a>
                             </li>
                         </ul>
                     </div>
diff --git a/src/ServicePulse.Host/app/js/views/pending_retries/view.html b/src/ServicePulse.Host/app/js/views/pending_retries/view.html
index 35b6e8ed10..5bce502b93 100644
--- a/src/ServicePulse.Host/app/js/views/pending_retries/view.html
+++ b/src/ServicePulse.Host/app/js/views/pending_retries/view.html
@@ -61,22 +61,22 @@
                                 </button>
                                 <ul class="dropdown-menu pull-right">
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('message_type', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Message Type</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('message_type', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Message Type</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('message_type', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Message Type</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('message_type', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Message Type</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('time_of_failure', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Failure</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('time_of_failure', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Failure</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('time_of_failure', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Failure</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('time_of_failure', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Failure</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('last_modified', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Retry request</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('last_modified', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Retry request</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectGroup('last_modified', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Retry request</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectGroup('last_modified', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Retry request</a>
                                     </li>
                                 </ul>
                             </div>