From 7ceae305d330fe5d56aa7f8e368d53dce8137570 Mon Sep 17 00:00:00 2001
From: WilliamBZA <william.brander@gmail.com>
Date: Mon, 4 Jun 2018 09:47:05 +0200
Subject: [PATCH] Remove other javascript: url references

---
 src/ServicePulse.Host/app/js/views/message/controller.js  | 4 ++++
 .../app/js/views/message/messages-view.html               | 2 +-
 .../app/js/views/pending_retries/view.html                | 8 ++++----
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/ServicePulse.Host/app/js/views/message/controller.js b/src/ServicePulse.Host/app/js/views/message/controller.js
index 8f587a337d..ece50396e9 100644
--- a/src/ServicePulse.Host/app/js/views/message/controller.js
+++ b/src/ServicePulse.Host/app/js/views/message/controller.js
@@ -46,6 +46,10 @@
             toastService.showInfo(messageId + ' copied to clipboard');
         };
 
+        vm.goBack = function () {
+            $window.history.go(-1);
+        };
+
         vm.togglePanel = function (message, panelnum) {
             if (message.notFound || message.error)
                 return false;
diff --git a/src/ServicePulse.Host/app/js/views/message/messages-view.html b/src/ServicePulse.Host/app/js/views/message/messages-view.html
index 0aead4465e..a4abde573e 100644
--- a/src/ServicePulse.Host/app/js/views/message/messages-view.html
+++ b/src/ServicePulse.Host/app/js/views/message/messages-view.html
@@ -4,7 +4,7 @@
     <section name="failed_message">
         <div class="row">
             <div class="col-sm-12">
-                <div><span class="fake-link">&#9664;</span> <a href="javascript:javascript:history.go(-1)">BACK</a></div>
+                <div><span class="fake-link">&#9664;</span> <a href="#" ng-click="$event.preventDefault();vm.goBack();">BACK</a></div>
                 <div ng-show="vm.message" class="active break group-title"><h1 class="message-type-title">{{vm.message.message_type}}</h1></div>
             </div>
         </div>
diff --git a/src/ServicePulse.Host/app/js/views/pending_retries/view.html b/src/ServicePulse.Host/app/js/views/pending_retries/view.html
index 5bce502b93..a801de69db 100644
--- a/src/ServicePulse.Host/app/js/views/pending_retries/view.html
+++ b/src/ServicePulse.Host/app/js/views/pending_retries/view.html
@@ -37,16 +37,16 @@
                                 </button>
                                 <ul class="dropdown-menu">
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectTimeGroup()">All Pending Retries</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup()">All Pending Retries</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectTimeGroup('2', 'hours')">Retried in the last 2 Hours</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('2', 'hours')">Retried in the last 2 Hours</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectTimeGroup('1', 'days')">Retried in the last 1 Day</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('1', 'days')">Retried in the last 1 Day</a>
                                     </li>
                                     <li>
-                                        <a href="javascript://" ng-click="vm.selectTimeGroup('7', 'days')">Retried in the last 7 Days</a>
+                                        <a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('7', 'days')">Retried in the last 7 Days</a>
                                     </li>
                                 </ul>
                             </div>