Skip to content

Conversation

@mikeminutillo
Copy link
Member

@mikeminutillo mikeminutillo commented Sep 27, 2019

Fixes #707

@mikeminutillo mikeminutillo self-assigned this Sep 27, 2019
@mikeminutillo
Copy link
Member Author

Not sure if this is really the best approach. You can see just above my change where we hide ALL checkboxes so all I did was turn this one back on specifically. All of the other ones in the system are either On/Off toggle buttons or a part of a multi-select grid. All of those get re-rendered as a different control.

@WilliamBZA
Copy link
Member

@sergioc might be a better reviewer here than me. @sergioc could you take a look?

@WilliamBZA WilliamBZA merged commit 419a8fd into master Oct 1, 2019
@WilliamBZA WilliamBZA deleted the missing-checkbox branch April 28, 2020 06:12
WilliamBZA added a commit that referenced this pull request Feb 17, 2023
Fixes missing checkbox on adding redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox now showing in Chrome when creating a redirect

3 participants