Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show discard with callbacks #4574

Closed
wants to merge 1 commit into from

Conversation

@danielmarbach
Copy link
Member

danielmarbach commented Oct 31, 2019

No description provided.

@@ -11,6 +12,15 @@ static async Task Main()
endpointConfiguration.UsePersistence<LearningPersistence>();
endpointConfiguration.UseTransport<LearningTransport>();

endpointConfiguration.Recoverability().CustomPolicy((config, context) =>
{
if (context.Exception is InvalidOperationException invalidOperationException && invalidOperationException.Message.StartsWith("No handlers could be found"))

This comment has been minimized.

Copy link
@ramonsmits

ramonsmits Nov 1, 2019

Member
Suggested change
if (context.Exception is InvalidOperationException invalidOperationException && invalidOperationException.Message.StartsWith("No handlers could be found"))
if (context.Exception is InvalidOperationException invalidOperationException && invalidOperationException.Message.StartsWith("No handlers could be found", StringComparison.OrdinalIgnoreCase))

This comment has been minimized.

Copy link
@danielmarbach

danielmarbach Nov 1, 2019

Author Member

Thanks ramon. The PR was only for demonstration purposes and I don't intend to bring it in or do you think this would be a valuable addition?

This comment has been minimized.

Copy link
@ramonsmits

ramonsmits Nov 1, 2019

Member

@danielmarbach I think this should be the default behavior for callbacks. Can't we make it into an issue for a maintenance release or maybe add this to the callback docs as a snippet?

This comment has been minimized.

Copy link
@danielmarbach

danielmarbach Nov 6, 2019

Author Member

I gave it a stab, see #4582

@danielmarbach danielmarbach deleted the callbacks-discard branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.