Skip to content

Commit cacfe38

Browse files
fix(filters): improve sorting dropdown item styles for better visibility
1 parent f389de1 commit cacfe38

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

dashboard/src/components/users/filters.tsx

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -159,19 +159,19 @@ export const Filters = ({ filters, onFilterChange, refetch, advanceSearchOnOpen,
159159
</DropdownMenuLabel>
160160
<DropdownMenuItem
161161
onClick={() => handleSort && handleSort('username')}
162-
className={filters.sort === 'username' ? 'bg-accent' : ''}
162+
className={`whitespace-nowrap ${filters.sort === 'username' ? 'bg-accent' : ''}`}
163163
>
164-
<User className="mr-2 h-4 w-4" />
165-
{t('sort.username.asc')}
166-
{filters.sort === 'username' && <ChevronDown className="ml-auto h-4 w-4 rotate-180" />}
164+
<User className="mr-2 h-4 w-4 flex-shrink-0" />
165+
<span className="truncate">{t('sort.username.asc')}</span>
166+
{filters.sort === 'username' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0 rotate-180" />}
167167
</DropdownMenuItem>
168168
<DropdownMenuItem
169169
onClick={() => handleSort && handleSort('-username')}
170-
className={filters.sort === '-username' ? 'bg-accent' : ''}
170+
className={`whitespace-nowrap ${filters.sort === '-username' ? 'bg-accent' : ''}`}
171171
>
172-
<User className="mr-2 h-4 w-4" />
173-
{t('sort.username.desc')}
174-
{filters.sort === '-username' && <ChevronDown className="ml-auto h-4 w-4" />}
172+
<User className="mr-2 h-4 w-4 flex-shrink-0" />
173+
<span className="truncate">{t('sort.username.desc')}</span>
174+
{filters.sort === '-username' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0" />}
175175
</DropdownMenuItem>
176176

177177
<DropdownMenuSeparator />
@@ -183,19 +183,19 @@ export const Filters = ({ filters, onFilterChange, refetch, advanceSearchOnOpen,
183183
</DropdownMenuLabel>
184184
<DropdownMenuItem
185185
onClick={() => handleSort && handleSort('expire')}
186-
className={filters.sort === 'expire' ? 'bg-accent' : ''}
186+
className={`whitespace-nowrap ${filters.sort === 'expire' ? 'bg-accent' : ''}`}
187187
>
188-
<Calendar className="mr-2 h-4 w-4" />
189-
{t('sort.expire.oldest')}
190-
{filters.sort === 'expire' && <ChevronDown className="ml-auto h-4 w-4 rotate-180" />}
188+
<Calendar className="mr-2 h-4 w-4 flex-shrink-0" />
189+
<span className="truncate">{t('sort.expire.oldest')}</span>
190+
{filters.sort === 'expire' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0 rotate-180" />}
191191
</DropdownMenuItem>
192192
<DropdownMenuItem
193193
onClick={() => handleSort && handleSort('-expire')}
194-
className={filters.sort === '-expire' ? 'bg-accent' : ''}
194+
className={`whitespace-nowrap ${filters.sort === '-expire' ? 'bg-accent' : ''}`}
195195
>
196-
<Calendar className="mr-2 h-4 w-4" />
197-
{t('sort.expire.newest')}
198-
{filters.sort === '-expire' && <ChevronDown className="ml-auto h-4 w-4" />}
196+
<Calendar className="mr-2 h-4 w-4 flex-shrink-0" />
197+
<span className="truncate">{t('sort.expire.newest')}</span>
198+
{filters.sort === '-expire' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0" />}
199199
</DropdownMenuItem>
200200

201201
<DropdownMenuSeparator />
@@ -207,19 +207,19 @@ export const Filters = ({ filters, onFilterChange, refetch, advanceSearchOnOpen,
207207
</DropdownMenuLabel>
208208
<DropdownMenuItem
209209
onClick={() => handleSort && handleSort('used_traffic')}
210-
className={filters.sort === 'used_traffic' ? 'bg-accent' : ''}
210+
className={`whitespace-nowrap ${filters.sort === 'used_traffic' ? 'bg-accent' : ''}`}
211211
>
212-
<ChartPie className="mr-2 h-4 w-4" />
213-
{t('sort.usage.low')}
214-
{filters.sort === 'used_traffic' && <ChevronDown className="ml-auto h-4 w-4 rotate-180" />}
212+
<ChartPie className="mr-2 h-4 w-4 flex-shrink-0" />
213+
<span className="truncate">{t('sort.usage.low')}</span>
214+
{filters.sort === 'used_traffic' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0 rotate-180" />}
215215
</DropdownMenuItem>
216216
<DropdownMenuItem
217217
onClick={() => handleSort && handleSort('-used_traffic')}
218-
className={filters.sort === '-used_traffic' ? 'bg-accent' : ''}
218+
className={`whitespace-nowrap ${filters.sort === '-used_traffic' ? 'bg-accent' : ''}`}
219219
>
220-
<ChartPie className="mr-2 h-4 w-4" />
221-
{t('sort.usage.high')}
222-
{filters.sort === '-used_traffic' && <ChevronDown className="ml-auto h-4 w-4" />}
220+
<ChartPie className="mr-2 h-4 w-4 flex-shrink-0" />
221+
<span className="truncate">{t('sort.usage.high')}</span>
222+
{filters.sort === '-used_traffic' && <ChevronDown className="ml-auto h-4 w-4 flex-shrink-0" />}
223223
</DropdownMenuItem>
224224
</DropdownMenuContent>
225225
</DropdownMenu>

0 commit comments

Comments
 (0)