merge 1.0.12 #132

volta2030 · 2025-12-07T00:23:36Z

No description provided.

1. toPIX --> toPix 2. toSharpBuffer --> toSharp

"PIX" to "Pix"

Co-authored-by: volta2030 <65960990+volta2030@users.noreply.github.com>

…-functionality Add HEIF/HEIC image format support

update pegasus app image

Co-authored-by: volta2030 <65960990+volta2030@users.noreply.github.com>

…r-rotation Add rotating dotted border effect during image drag-and-drop

Copilot

Pull request overview

This PR merges version 1.0.12, which adds support for new image formats (PIX, HEIF, HEIC), enhances the pad feature with configurable background color, refactors color picker functionality, and adds visual feedback for drag-and-drop operations.

Added PIX format support with custom JSON-based image data structure
Enhanced pad feature to accept custom background colors
Moved color name resolution from renderer to main process for better architecture
Added animated border effect during drag-and-drop operations
Added HEIF/HEIC format support

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
package.json	Version bump to 1.0.12 and added jsonfile dependency
package-lock.json	Dependency updates including jsonfile hoisting and minor version bumps for electron, glob, and form-data
imgkit/core/pix.js	New module for PIX format handling with read/write/conversion methods
imgkit/processing/image_loader.js	Added PIX format loading support in openImage, openFromBuffer, getImageLoader, and getBufferLoader
imgkit/processing/format_converter.js	Added conversion methods for PIX and HEIF/HEIC formats
imgkit/core/image_layer.js	Added PIX format save logic
imgkit/processing/image_processor.js	(Context) Contains getColorName method used in color picker refactoring
main.js	Refactored color picker to compute color names in main process; added HEIF/HEIC/PIX to file dialog filters; renamed cropImgREQ to rectCropImgREQ
renderer/paint_renderer.js	Added padColor variable and event listener for color input
renderer/main_renderer.js	Updated padImgCMD handler to accept color parameter
renderer/crop_renderer.js	Added rectCropBtn click handler
pages/paint_panel.html	Added UI elements for pad color selection
pages/crop_panel.html	Added rectCrop button
imgkit/index.html	Added PIX, HEIF, and HEIC format options to extension dropdown
imgkit/imgpanel.css	Added rotating border animation for drag-over state
css/paint_panel.css	Added styles for padColorBox and padColorValue
imgkit/features/image_layer_events.js	Refactored color picker to send color without name; added drag-border-active animation class management; added clipboard write for color palette clicks
imgkit/core/main_renderer.js	Formatting adjustment for ternary operator
assets/pix.pix	Sample PIX format file with metadata
README.md	Updated supported file extensions list and screenshot
PRIVACYPOLICY.md	Removed privacy policy file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

imgkit/processing/image_loader.js

Copilot · 2025-12-07T00:28:08Z

pages/paint_panel.html

-      <input id="padValue" type="number" min="1" value="1" step="1" />
+      <div id="padColorBox"></div>
+      <div id="padIndicator">
+        <input id="padColorValue" type="text" value="#000000" />


[nitpick] Consider using type="color" instead of type="text" for the padColorValue input to provide a native color picker UI and ensure valid color values are entered.

Suggested change

<input id="padColorValue" type="text" value="#000000" />

<input id="padColorValue" type="color" value="#000000" />

Copilot · 2025-12-07T00:28:08Z

imgkit/processing/image_loader.js

+    if (extension == "pix") {
+      const pixData = Pix.open(filepath);
+      return Pix.toSharp(pixData);
+    }


The methods getImageLoader and getBufferLoader both call Pix.toSharp() but don't handle the case where it returns null (which can happen if the PIX data is invalid). This could cause issues downstream. Consider adding error handling or validation.

imgkit/processing/image_loader.js

Copilot · 2025-12-07T00:28:09Z

imgkit/core/pix.js

+    if (raw.length < expectedLength) raw.fill(0, raw.length, expectedLength);
+
+    return sharp(raw, {


The buffer filling logic may not work correctly when raw.length < expectedLength. Using fill() on the existing buffer doesn't extend it. Consider using Buffer.concat([raw, Buffer.alloc(expectedLength - raw.length)]) to properly pad the buffer to the expected length.

Suggested change

if (raw.length < expectedLength) raw.fill(0, raw.length, expectedLength);

return sharp(raw, {

const paddedRaw = raw.length < expectedLength

? Buffer.concat([raw, Buffer.alloc(expectedLength - raw.length)])

: raw;

return sharp(paddedRaw, {

Copilot · 2025-12-07T00:28:09Z

imgkit/processing/format_converter.js

+    const pngResult = await Pix.toSharp(pixData);
+
+    return { buffer: pngResult.data, info: metadata };


The convertToPix method converts an image to PIX format and then immediately converts it back to PNG via Pix.toSharp(). This defeats the purpose of format conversion. The method should return the PIX data buffer (e.g., JSON.stringify(pixData)) instead of converting it back to PNG. Consider: return { buffer: Buffer.from(JSON.stringify(pixData, null, 2)), info: metadata };

Suggested change

const pngResult = await Pix.toSharp(pixData);

return { buffer: pngResult.data, info: metadata };

return { buffer: Buffer.from(JSON.stringify(pixData, null, 2)), info: metadata };

Copilot · 2025-12-07T00:28:09Z

renderer/paint_renderer.js

+document.getElementById("padColorValue").addEventListener("input", (event) => {
+  padColor = event.target.value;
+  document.getElementById("padColorBox").style.backgroundColor = padColor;


The padColor input lacks validation. Consider adding validation to ensure the value is a valid hex color (e.g., using a regex like /^#[0-9A-Fa-f]{6}$/) before using it. Invalid color values could cause issues with the Sharp library's extend operation.

Copilot · 2025-12-07T00:28:09Z

imgkit/processing/image_loader.js

+    if (extension == "pix") {
+      const pixData = Pix.openFromBuffer(buffer);
+      return Pix.toSharp(pixData);
+    }


The methods getImageLoader and getBufferLoader both call Pix.toSharp() but don't handle the case where it returns null (which can happen if the PIX data is invalid). This could cause issues downstream. Consider adding error handling or validation.

imgkit/core/image_layer.js

Copilot · 2025-12-07T00:28:10Z

imgkit/core/pix.js

+  static async toPix(buffer, info) {
+    const { data, info: rawInfo } = await sharp(buffer)


Unused variable rawInfo.

Suggested change

static async toPix(buffer, info) {

const { data, info: rawInfo } = await sharp(buffer)

static async toPix(buffer) {

const { data, info } = await sharp(buffer)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

volta2030 and others added 28 commits November 16, 2025 19:17

feat: add px span in pad

3954a7a

fix: devide to rect crop

9554ac5

fix: remove PRIVACYPOLICY (Never need)

1f14322

feat: add PIX moudle

c5078c4

feat: add clipboard for color picker #125

7f91db7

feat: npm update

b757546

fix: change PIX load() name to open() & add convertToPIX()

bb8389c

feat: add open & save for pix extension

e10ce00

fix: change PIX module function name...

fa3745d

1. toPIX --> toPix 2. toSharpBuffer --> toSharp

fix: rename moudle import name

896743b

"PIX" to "Pix"

feat: add compression & label section in toPix()

b12f1b4

feat: add padColorBox

4c91701

feat: add padColorValue

1b0db81

fix: add color to pad command

20caa8a

fix: including # to padColor

a2acad0

feat: enable changing padColorBox by padColorValue #126

ce7aecd

Initial plan

0c400b1

Add HEIF/HEIC image format support

bacb4d1

Co-authored-by: volta2030 <65960990+volta2030@users.noreply.github.com>

feat: add heif, heic selection into extension-combo selection

a86b23d

Merge pull request #127 from Pascal-Institute/copilot/add-heif-opener…

2feed6f

…-functionality Add HEIF/HEIC image format support

Update README.md

11bf7cd

update pegasus app image

feat: add joint section by pix spec in toPix()

d0aeece

feat: link colorBox to colorPicker #128

07ffa05

Initial plan

72fbfad

Add rotating dotted border effect during image drag-and-drop

8835bdf

Co-authored-by: volta2030 <65960990+volta2030@users.noreply.github.com>

Fix code review issues: improve animation and dragleave handling

37228be

Co-authored-by: volta2030 <65960990+volta2030@users.noreply.github.com>

Merge pull request #130 from Pascal-Institute/copilot/add-image-borde…

e35f446

…r-rotation Add rotating dotted border effect during image drag-and-drop

feat: Version Up

79bab6a

volta2030 requested a review from Copilot December 7, 2025 00:23

Copilot started reviewing on behalf of volta2030 December 7, 2025 00:24 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

volta2030 and others added 4 commits December 7, 2025 09:29

Update imgkit/processing/image_loader.js

23af15b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update imgkit/processing/image_loader.js

3041ab7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update imgkit/core/image_layer.js

b20ae25

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: add return statement when pix save & add missing version up tag

f86edda

volta2030 merged commit 23b0afa into publish Dec 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

merge 1.0.12 #132

merge 1.0.12 #132

Uh oh!

volta2030 commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<input id="padColorValue" type="text" value="#000000" />
	<input id="padColorValue" type="color" value="#000000" />

		if (raw.length < expectedLength) raw.fill(0, raw.length, expectedLength);

		return sharp(raw, {

-    if (raw.length < expectedLength) raw.fill(0, raw.length, expectedLength);
-    return sharp(raw, {
+    const paddedRaw = raw.length < expectedLength
+      ? Buffer.concat([raw, Buffer.alloc(expectedLength - raw.length)])
+      : raw;
+    return sharp(paddedRaw, {

		const pngResult = await Pix.toSharp(pixData);

		return { buffer: pngResult.data, info: metadata };

		static async toPix(buffer, info) {
		const { data, info: rawInfo } = await sharp(buffer)

merge 1.0.12 #132

merge 1.0.12 #132

Uh oh!

Conversation

volta2030 commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants