Imgkit refactoring #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove imgkit/index.js (merged into renderer.js) - Remove imgkit/README.md (outdated standalone docs) - Prepare for imgkit integration into main Pegasus app
- Add imgPanel template as separate HTML component - Create dedicated CSS file for imgPanel styles - Merge imgkit UI elements into main index.html - Improve UI modularity and maintainability
- Create imgkit/image-layer.js with complete ImageLayer implementation - Move all image panel logic from renderer.js to image-layer.js - Implement lazy loading pattern to avoid circular dependencies - Add comprehensive error handling and validation - Improve code organization and maintainability - Add focus indicator with CSS :focus pseudo-selector
- Add applyCrop() method for precise cropping with validation - Add updateFileExtension() helper for file path manipulation - Improve openImageBuffer() and openImage() methods - Enhance color extraction algorithm - Update package.json entry point configuration - Move all Sharp library operations to backend layer - Improve error handling and validation
- Fix main_renderer.js drag & drop functionality - Update paint_renderer.js to work with new ImageLayer structure - Remove redundant conditions and improve code quality - Fix convertFormat() integration - Improve file handling in drop events
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the imgkit module for better Electron integration, transitioning from a monolithic architecture to a clean 3-tier structure. The changes improve maintainability, separation of concerns, and provide better TypeScript support.
- Refactored from single-file to 3-tier architecture (main.js, renderer.js, image-layer.js)
- Replaced deprecated callback-based Sharp API with modern async/await pattern
- Added comprehensive documentation and improved error handling
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| renderer/paint_renderer.js | Removed imgkit dependency and added local state management for draw flag |
| renderer/main_renderer.js | Updated to use new imgkit API with async/await and improved error handling |
| pages/imgpanel_template.html | Added HTML template for image panel structure |
| index.html | Integrated imgkit UI elements and template into main HTML |
| imgkit/renderer.js | New presentation layer managing UI container and scroll behavior |
| imgkit/package.json | Updated package configuration with new version and exports |
| imgkit/main.js | New business layer with core image processing logic |
| imgkit/index.js | Removed old monolithic implementation |
| imgkit/image-layer.js | New component layer for individual image panel management |
| imgkit/README.md | Added comprehensive documentation for the new architecture |
| css/imgpanel.css | Added styles for the new imgkit UI components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transistion to electron formfactor