Skip to content

Conversation

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator

  • updates SDL2_ttf.pas to Version 2.21.0
  • one exception: deprecated, conditional macro SDL_TTF_COMPILEDVERSION
  • updates all comments
  • beautifies code according to our style guide

@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website merged commit 23d5e3b into PascalGameDevelopment:master Nov 10, 2022
@suve
Copy link
Collaborator

suve commented Nov 11, 2022

SDL2_ttf 2.21.0 has not been released yet, but the definitions seem to match what's currently on upstream's main branch. Thanks and sorry for taking so long to review this.

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator Author

Hey, no harm done. Thanks for reviewing.

Lately I translate directly from upstream, maybe I should use a version tag like "2.21.0 upstream" to reflect this.

@suve
Copy link
Collaborator

suve commented Nov 12, 2022

You can always click on the "tags" / "releases" bit in GitHub's interface and use that to browse the code as it looked during latest release. Though I don't think translating directly from main should be much of an issue - SDL takes backwards compatibility very seriously.

@normaluser
Copy link

normaluser commented Nov 12, 2022 via email

@suve
Copy link
Collaborator

suve commented Nov 12, 2022

Please open a new issue for this and attach some details about the compilation errors you get.

@normaluser
Copy link

normaluser commented Nov 13, 2022 via email

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator Author

@normaluser Thanks for the report! Thanks to @suve's fix this issue should be gone by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants