From 289c8772a8448c580753b3313d6e3f9f7c64c963 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Thu, 10 Jun 2021 07:38:18 +0200 Subject: [PATCH] Merge bitcoin/bitcoin#22204: doc: remove obsolete `okSafeMode` RPC guideline from developer notes 6780a095d8526a46c3c2b20a14831687e9fc2462 doc: remove obsolete `okSafeMode` RPC guideline from developer notes (Sebastian Falbesoner) Pull request description: Since the flag has been removed from the RPC command table in commit ec6902d0ea2bbe75179684fc71849d5e34647a14 (PR #11179), this guideline is not relevant anymore and can be removed. ACKs for top commit: MarcoFalke: ACK 6780a095d8526a46c3c2b20a14831687e9fc2462. Also, safe mode was removed completely in commit 2ae705d84178fb9faa49f92091206e92379a2c63 Tree-SHA512: 2a6b002ae302e979ce403171b79a892e32f5083792c3b0b8204edb5eb08c6b24ab77bbeeae0e3bb6d6564a6f1678cfce00eb7b5b82063b7741f89a96b0c0aef3 --- doc/developer-notes.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/doc/developer-notes.md b/doc/developer-notes.md index 9e13bf4ff8a78..f0c531e90ea87 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -908,13 +908,6 @@ A few guidelines for introducing and reviewing new RPC interfaces: - *Rationale*: If not, the call can not be used with name-based arguments. -- Set okSafeMode in the RPC command table to a sensible value: safe mode is when the - blockchain is regarded to be in a confused state, and the client deems it unsafe to - do anything irreversible such as send. Anything that just queries should be permitted. - - - *Rationale*: Troubleshooting a node in safe mode is difficult if half the - RPCs don't work. - - Add every non-string RPC argument `(method, idx, name)` to the table `vRPCConvertParams` in `rpc/client.cpp`. - *Rationale*: `dash-cli` and the GUI debug console use this table to determine how to