From 6780a095d8526a46c3c2b20a14831687e9fc2462 Mon Sep 17 00:00:00 2001 From: Sebastian Falbesoner Date: Thu, 10 Jun 2021 01:56:09 +0200 Subject: [PATCH] doc: remove obsolete `okSafeMode` RPC guideline from developer notes Since the flag has been removed from the RPC command table in commit ec6902d0ea2bbe75179684fc71849d5e34647a14 (PR #11179), this guideline is not relevant anymore and can be removed. --- doc/developer-notes.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/doc/developer-notes.md b/doc/developer-notes.md index 2130332eec880..c3a63b3523812 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -1160,13 +1160,6 @@ A few guidelines for introducing and reviewing new RPC interfaces: - *Rationale*: If not, the call can not be used with name-based arguments. -- Set okSafeMode in the RPC command table to a sensible value: safe mode is when the - blockchain is regarded to be in a confused state, and the client deems it unsafe to - do anything irreversible such as send. Anything that just queries should be permitted. - - - *Rationale*: Troubleshooting a node in safe mode is difficult if half the - RPCs don't work. - - Add every non-string RPC argument `(method, idx, name)` to the table `vRPCConvertParams` in `rpc/client.cpp`. - *Rationale*: `bitcoin-cli` and the GUI debug console use this table to determine how to