Skip to content

Rough Aurabot Exporter#2927

Closed
NathanielHinshaw wants to merge 33 commits into
PathOfBuildingCommunity:devfrom
NathanielHinshaw:dev
Closed

Rough Aurabot Exporter#2927
NathanielHinshaw wants to merge 33 commits into
PathOfBuildingCommunity:devfrom
NathanielHinshaw:dev

Conversation

@NathanielHinshaw
Copy link
Copy Markdown

Super rough aurabot exporter, requires you to add a minion to the build, hover over the calc'd buff window on the calc's tab with minion stats selected, and then click the export button. first time ever using Lua, so its pretty hacky, but it could come in handy down the line, if somebody who had a better understanding of Lua and/or the application design were to redesign it

@PJacek PJacek added enhancement New feature, calculation, or mod help wanted Extra attention is needed long term Large or strategic commitments labels Jul 23, 2021
@NathanielHinshaw
Copy link
Copy Markdown
Author

not sure how to resolve that last commit, my git skills are a bit lacking

Super rough aurabot exporter, requires you to add a minion to the build, hover over the calc'd buff window on the calc's tab, and then click the export button.  first time ever using Lua, so its pretty hacky, but good proof of concept for future use
fixed a couple of things that were parsing wrong, changed the jewel type
did a fresh pull and rechanged the aurabot exporter to work properly with the new master branch changes.

functionally this is still the same and should be rewritten, but it was no longer compatible with the new uniques/small clusters, so this fixes that.
attack speed/cast speed calculations were broken, fixed them
fixing the EXE naming as well
Added support for defensive auras

Specifically Purities, Defiance Banner, Determination, Alt-quality Determination, Grace, Clarity and Vitality
next commit will have the aurabot exporter changes back in it
Merged up-to-date PoB code in to fix merge issues,  added back in aurabot exporter code.

The most recent commit adds support for defensive auras in the jewel.
Quick change to add vaal grace in
updating CalcBreakdownControl to newer code from real release
updating CalcsTab to properly align with the new codebase
Put in some boundary checks on any buffs that get added together, makes sure they exist before it puts them in the jewel

added PdR calculations
Super rough aurabot exporter, requires you to add a minion to the build, hover over the calc'd buff window on the calc's tab, and then click the export button.  first time ever using Lua, so its pretty hacky, but good proof of concept for future use
fixed a couple of things that were parsing wrong, changed the jewel type
did a fresh pull and rechanged the aurabot exporter to work properly with the new master branch changes.

functionally this is still the same and should be rewritten, but it was no longer compatible with the new uniques/small clusters, so this fixes that.
attack speed/cast speed calculations were broken, fixed them
fixing the EXE naming as well
Added support for defensive auras

Specifically Purities, Defiance Banner, Determination, Alt-quality Determination, Grace, Clarity and Vitality
next commit will have the aurabot exporter changes back in it
Merged up-to-date PoB code in to fix merge issues,  added back in aurabot exporter code.

The most recent commit adds support for defensive auras in the jewel.
Quick change to add vaal grace in
updating CalcBreakdownControl to newer code from real release
updating CalcsTab to properly align with the new codebase
Put in some boundary checks on any buffs that get added together, makes sure they exist before it puts them in the jewel

added PdR calculations
fixing the rebase to have the newest dev branch
Nuking the breanch to fix some stuff
adding back in aurabot exporter features
added check for vaal disc new mod in aura panel
@QuickStick123
Copy link
Copy Markdown
Contributor

Superseded by #4967

NathanielHinshaw and others added 4 commits December 6, 2022 20:02
Fixed projectile speed mod not being captured.  changed wording on Hatred handler to be a bit more readable.
…pport

Re-based repo to update the rest of the codebase,  added Vaal Smite support
+ added Movement Speed mod to the ExportAuraString
+ added condition for defiance banner reduced Critical strike chance
concat on movement speed for vaal/regular haste checks
@NathanielHinshaw
Copy link
Copy Markdown
Author

@QuickStick123 this doesn't do quite the same thing as the PR that got merged

@QuickStick123
Copy link
Copy Markdown
Contributor

What is it trying to accomplish I assume it is produce a list of parsable mods usable in PoB? I assumed the usage as putting an aurabot's buffs on another character was its primary purpose which the party tab solves.

@NathanielHinshaw
Copy link
Copy Markdown
Author

its fairly close, this generates that list of buffs into an item that you can import into other builds, but generation of that item allows you to send a list of your buffs without having a properly un-private profile

in addition, and this might not still be relevant, but previously it was difficult to cycle on and off the buffs in the page, but that may have been fixed in a recent commit (noting it because as a separate "buff" item, you can cycle on or off the socket holding the stat-block

@Regisle
Copy link
Copy Markdown
Member

Regisle commented Apr 28, 2023

yeah its much easier to cycle now, and it is possible to send the xml culled of almost everything excluding the exported mods if your worried about build being leaked, though doing that requires a bit of effort

you could also just copy the mods from the advanced view though and they can paste it in (and click rebuild) but thats 2-5 copy/pastes instead of 1

@NathanielHinshaw
Copy link
Copy Markdown
Author

assuming that's true, then I agree, no need for this given some sort of culled XML support, as well as a means to cycle the buffs on/off, well done! @Regisle

I personally run a public profile, but I know a ton of aura-supports the were using this PR don't

@QuickStick123
Copy link
Copy Markdown
Contributor

Yeah there could probably be some improvements made to get your one click export kinda thing working again so feel free to open another PR working on updating the party tab to do this or any other improvements you feel are appropriate.

@NathanielHinshaw
Copy link
Copy Markdown
Author

for sure, thanks for all the work y'all do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod help wanted Extra attention is needed long term Large or strategic commitments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants