Avoid resolving empty folders#901
Merged
Merged
Conversation
Pathoschild
added
the
enhancement
Pathoschild
approved these changes
Mar 26, 2023
Pathoschild
changed the title
Owner
|
Merged into |
Pathoschild
added a commit
that referenced
this pull request
Apr 9, 2023
Avoid resolving empty folders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr the modsToLoadEarly/modsToLoadLate weren't excluding mods that didn't load, leading to null references like so: https://smapi.io/log/ca072e943a4f488c82be1e9c9341d6c9
For an example, see the repo pack below. (just move the config file to smapi-internal)
Mods.zip