Add string methods visitor code to support all OData string methods #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods which don't need special attention. But we are covering our bases!
Collaborator
Author
|
They don't work with nested methods (e.g. toupper(substring(Name, 1, 2))) yet. Will have to add more thorough tests and refactor the code to be more recursive / awesomer. |
Owner
|
Sorry for the slow response! This looks fine. I added you as a contributor so you can commit changes directly. :) |
cdroulers
added a commit
that referenced
this pull request
Jun 18, 2015
Add string methods visitor code to support all OData string methods
Collaborator
Author
|
Can you add me as an author on nuget.org so I can build and push the package? |
Owner
|
Sure. What's your NuGet username? |
Collaborator
Author
|
cdroulers |
Owner
|
Fair enough. You can now manage to the NuGet package too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.odata.org/documentation/odata-version-2-0/uri-conventions/#FilterSystemQueryOption
All the functions from the top of the table are supported now!
Tests were added!