Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Excapes not handled by termion cause panic #61

Closed
joelakuhn opened this issue Mar 2, 2022 · 1 comment
Closed

CSI Excapes not handled by termion cause panic #61

joelakuhn opened this issue Mar 2, 2022 · 1 comment

Comments

@joelakuhn
Copy link

Some valid escape sequences like shift+right (1;2C) are not properly parsed by termion and therefore return an Err result. This causes a panic in the input loop of App.run, which unwraps the event variable yielded by the input iterator.

@PaulJuliusMartinez
Copy link
Owner

Ah, I think I expected errors like this to be returned using the Event::Unsupported variant. Evidently not the case.

I've removed the unwrap and provided actual error handling in b681708. (I should clarify the error prefix from Error: to something like Input Error: or Error getting user input: though... An inadvertent key press may result in a confusing error message. I'll think about it.)

Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants