Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on lots of news sites? #15

Closed
dmil opened this issue May 11, 2022 · 6 comments
Closed

Not working on lots of news sites? #15

dmil opened this issue May 11, 2022 · 6 comments

Comments

@dmil
Copy link

dmil commented May 11, 2022

Thanks for making this great plugin! I was hoping to use it to grab titles from news sites that I plan to read, but I'm realizing it's not always working for news articles, even when a <title> tag is present. I'm not totally sure what the issue is or how to debug a LogSeq plugin, but here are a few examples of where I found it doesn't work.

works on:

doesn't work on:

Thanks again!

@PaulKinlan
Copy link
Owner

I'll investigate. Thanks for giving some sample links. One thing I found is that it doesn't work for Twitter because it "requires" JavaScript so it might be something similar.

@PaulKinlan
Copy link
Owner

I just checked. https://awilkinson.medium.com/the-power-of-anti-goals-c38f5f46d23c is the only one it doesn't work on for me, and that has a <title> element of <title data-rh="true".. I can fix this one pretty easily.

@PaulKinlan
Copy link
Owner

It should be better now. Can you check? (fixed in c027779)

@piyush-das
Copy link

piyush-das commented Jun 4, 2022

Hi, tried the latest release but still fails to work for the following link : https://leetcode.com/problems/n-queens/
It resolves as [Loading...](https://leetcode.com/problems/n-queens/)

@PaulKinlan
Copy link
Owner

That's because the site uses JavaScript to update the title. This extension right now can't run JS on those pages

@dmil
Copy link
Author

dmil commented Jun 15, 2022

Worked great on all three of the ones I had initially cited. Thank you!!!

@dmil dmil closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants