Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more transfer functions for Teensy 4.x #62

Merged
merged 1 commit into from Oct 25, 2020

Conversation

vjmuzik
Copy link
Contributor

@vjmuzik vjmuzik commented Oct 23, 2020

  • Add transfer16 buffer
  • Add transfer32
  • Add transfer32 buffer

- Add transfer16 buffer
- Add transfer32
- Add transfer32 buffer
@KurtE
Copy link
Contributor

KurtE commented Oct 24, 2020

@vjmuzik and @PaulStoffregen

Earlier when I added the transfer buffer stuff, I had a transfer16 with buffer as well and at that time it was decided not to add it...
And I removed it from that Pull Request.

Personally I would like these. However that if we add the 16 bit versions, we should add them also for the T3.x and LC

And likewise if this is approved, that we add the asynchronous versions of these as well.

As for 32 bit, it is only supported by the T4.x boards and I believe it might help some performance. I have used it in some of the HX8357 code to transfer 24 bit pixels (obviously not SPI library stuff. How much it helped in this case unclear as I was doing it from EXTMEM areas which is relatively slow.

@PaulStoffregen
Copy link
Owner

These buffer transfer functions are not going to become part of the public API. I'm going to merge this, and then make them private. We need to extend the normal transfer function to use these.

@PaulStoffregen PaulStoffregen merged commit fe02d97 into PaulStoffregen:master Oct 25, 2020
@KurtE
Copy link
Contributor

KurtE commented Oct 25, 2020

Hi @PaulStoffregen

Might make them protected instead of private, then could simply subclass...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants