Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

fixed: make check agains Collection type work #294

Merged
merged 1 commit into from

2 participants

@aronwoost

Wasted an hour to find my error (Collection extended from a Model). This will hopefully save it for everyone coming after me.

@PaulUithol
Owner

Ah, nasty. I've checked all other instanceof checks, this seems to be the only faulty one. Thanks!

@PaulUithol PaulUithol merged commit 8bfdf03 into from
@philfreo philfreo referenced this pull request from a commit in philfreo/Backbone-relational
@philfreo philfreo Allow collectionType to fallback to generic Backbone.Collection.
Fixes tests / functionality broken by 8bfdf03 / #294
f120fa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 18, 2013
  1. @aronwoost
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  backbone-relational.js
View
2  backbone-relational.js
@@ -812,7 +812,7 @@
if ( _.isString( this.collectionType ) ) {
this.collectionType = Backbone.Relational.store.getObjectByName( this.collectionType );
}
- if ( !this.collectionType.prototype instanceof Backbone.Collection ){
+ if ( !(this.collectionType.prototype instanceof Backbone.Collection) ){
throw new Error( '`collectionType` must inherit from Backbone.Collection' );
}
Something went wrong with that request. Please try again.