Failed reverse relation #315

Merged
merged 2 commits into from Mar 29, 2013

Conversation

Projects
None yet
2 participants
Collaborator

philfreo commented Mar 29, 2013

this is the same test as the one before it, with the exception of the first 3 lines, but this makes it fail

I also tried passing a merge option in nodes.set, but that didn't help

Owner

PaulUithol commented Mar 29, 2013

Well, that's interesting. I'll have a look.

@PaulUithol PaulUithol added a commit that referenced this pull request Mar 29, 2013

@PaulUithol PaulUithol Merge pull request #315 from elasticsales/failed-reverse-relation
Add a test case showing failing reverse relation
e03d00b

@PaulUithol PaulUithol merged commit e03d00b into PaulUithol:master Mar 29, 2013

Owner

PaulUithol commented Mar 29, 2013

Uhm.. I can't seem to re-open this one after merging the pull? Anyway, looks like this is very much related to the other test case. By explicitly creating the parent before setting the collection, we don't get to the code preventing options.collection from cascading to nested models.

philfreo deleted the closeio:failed-reverse-relation branch Mar 29, 2013

Collaborator

philfreo commented Apr 1, 2013

Yeah Pulls can't be opened once they're merged. This seems like the last issue stopping me from upgrading my project to backbone 1.0. I tried a few things to fix this but without luck -- would really appreciate any ideas you had on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment