New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #360. Adds support for deep subModelType hierarchies. #362

Merged
merged 3 commits into from Jul 23, 2013

Conversation

Projects
None yet
3 participants
@gmcnaughton
Contributor

gmcnaughton commented Jun 13, 2013

Recursively resolve the appropriate subModelType to instantiate in
'Backbone.RelationalModel.build'. This allows subModelTypes to in turn declare
their own subModelTypes.

gmcnaughton and others added some commits Jun 13, 2013

Fixes #360. Adds support for deep subModelType hierarchies.
Recursively resolves the appropriate subModelType to instantiate in
'Backbone.RelationalModel.build'. This allows subModelTypes to in turn declare
their own subModelTypes.
Pulling the relation-inheritance logic out of Backbone.RelationalMode…
…l.initializeModelHierarchy into it's own method so that initializing super-class relations doesn't cause the super-class's model hierarchy to become initialized. There are situations where initializing the super-class's model hierarchy during relation inheritance will prevent some relations from being inherited. Updated the logic in Backbone.RelationalModel.initializeModelHierarchy that recursively initializes the model hierarchy of subModels so that it doesn't initialize models that have already been initialized.
@PaulUithol

This comment has been minimized.

Show comment
Hide comment
@PaulUithol

PaulUithol Jul 10, 2013

Owner

Looks like a great feature! I'll hopefully get around to reviewing it properly this week or beginning of next week.

Owner

PaulUithol commented Jul 10, 2013

Looks like a great feature! I'll hopefully get around to reviewing it properly this week or beginning of next week.

PaulUithol added a commit that referenced this pull request Jul 23, 2013

Merge pull request #362 from kartofflly/deep-submodeltype-hierarchies
Fixes #360. Adds support for deep subModelType hierarchies.

@PaulUithol PaulUithol merged commit bf6a2b5 into PaulUithol:master Jul 23, 2013

@gmcnaughton gmcnaughton deleted the curious:deep-submodeltype-hierarchies branch Jul 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment