Add spaces to X-SMTP header #3

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@ignovak

ignovak commented May 3, 2012

Hi

Sending emails to large number of recipients I've encountered such error:

A message was received from this address by our systems that had errors in the smtpapi header, and cannot be processed.
The error detected was: Error decoding SMTP API header

The reason was in X-SMTP header, which was too large and was not broken down with spaces properly.
The way how to avoid this problem is described here: http://docs.sendgrid.com/documentation/api/smtp-api/developers-guide/

This pull-request adds spaces to header, so problem seems to be resolved.
There is one drawback there that header size increases 1.5 times. You can probably find better solution.

Thanks

@gtd

This comment has been minimized.

Show comment
Hide comment
@gtd

gtd Jun 27, 2012

Contributor

I'm migrating from the sengrid gem to this one which appears much better designed, and I'm about to start sending emails in batches of 1000. This looks like a legitimate problem that I'd rather solve before I get burned in production. Any comment on merging this down Pavel? I'd be willing to contribute to a better solution if you want.

Contributor

gtd commented Jun 27, 2012

I'm migrating from the sengrid gem to this one which appears much better designed, and I'm about to start sending emails in batches of 1000. This looks like a legitimate problem that I'd rather solve before I get burned in production. Any comment on merging this down Pavel? I'd be willing to contribute to a better solution if you want.

@gtd

This comment has been minimized.

Show comment
Hide comment
@gtd

gtd Jun 27, 2012

Contributor

Alright I see this pull request is broken, working on a proper solution now.

Contributor

gtd commented Jun 27, 2012

Alright I see this pull request is broken, working on a proper solution now.

@PavelTyk

This comment has been minimized.

Show comment
Hide comment
@PavelTyk

PavelTyk Jun 28, 2012

Owner

Thank you for help. Released v2.0.2 with fix for this issue.

Owner

PavelTyk commented Jun 28, 2012

Thank you for help. Released v2.0.2 with fix for this issue.

@PavelTyk PavelTyk closed this Jun 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment