-
Notifications
You must be signed in to change notification settings - Fork 0
Hotfix 1.1.3 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hotfix 1.1.3 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac3ecaf to
71d248e
Compare
583cf6b to
ad9cf21
Compare
arteymix
commented
Jun 22, 2022
| * Exception raised when retrying a search without a wildcard still fails. | ||
| * @author poirigui | ||
| */ | ||
| public class RetryWithoutWildcardFailedException extends OntologySearchJenaException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just RetryFailedException would be more appropriate as a name? I'm sure there's more than one way to retry a query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
log.errorhave been switched tolog.warn. I also removed the debug enabled check, since SLF4J can do lazy to-string with parametrized logging.I introduced the following exception hierarchy:
Callers should always handle
OntologySearchExceptionwhich is not necessarily Jena-related. If it is, there are more specialized exception types.All exceptions include the query string used to perform the search. I try to be careful and never log the query itself because it can be pretty big if many clauses are used. If you need to render the query, just catch the exception and print it somewhere, preferably safely.