Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies #26

Merged
merged 1 commit into from Apr 19, 2016
Merged

Pin dependencies #26

merged 1 commit into from Apr 19, 2016

Conversation

@kvz
Copy link
Contributor

@kvz kvz commented Jan 11, 2016

This helps against things suddenly exploding in your face, such as our deploys today because xmldom slipped a not-so-backwards-compatible update in a patch version. Who can blame them, it's impossible to know all the different ways people are using your project and what effects a minor change might have, and how that might break things in subtle or not so subtle ways for them.

Long story short, let's pin dependencies so any change is explicit & tested, and our builds and deploys are reproducible.

See #25

@sbstnmsch
Copy link

@sbstnmsch sbstnmsch commented Jan 12, 2016

This fixes #25 for me. +1 for merging this into 1.0.5

@Pavliko
Copy link
Owner

@Pavliko Pavliko commented Apr 19, 2016

Thank you for your job 👍

@Pavliko Pavliko merged commit 4d3c58f into Pavliko:master Apr 19, 2016
@sbstnmsch
Copy link

@sbstnmsch sbstnmsch commented Apr 19, 2016

Just my recommendation - using travis-ci together with greenkeeper.io will automagically test and PR when new versions arrive on NPM - keeping everything green and up-to-date. Maybe i have time to spent on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.