Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opening paycoin: URIs directly. #282

Merged
merged 1 commit into from Feb 16, 2016

Conversation

MitchellCash
Copy link
Contributor

@IngCr3at1on it's finally done and testing on Windows is finally working. To be honest I should have kept looking into this when I started a few months ago and I could have had it done then but I got distracted with other things.

@IngCr3at1on
Copy link
Contributor

Just for curiosity was it that one check that I pointed out?

@IngCr3at1on
Copy link
Contributor

qtipcserver.h still uses has #define BITCOINURI_QUEUE_NAME "BitcoinURI" let's change that if possible.

@MitchellCash
Copy link
Contributor Author

@IngCr3at1on I overlooked removing one of the #if !defined(MAC_OSX) && !defined(WIN32) lines. It frustrates me I stopped looking at this because all I had to do was remove that line and it could have solved all my problems months ago.

In regards to renaming BitcoinURI I'm happy to do that. Before I do this though would you also like me to go through the codebase and replace parseBitcoinURI with parsePaycoinURI etc.

There are so many references to Bitcoin in the codebase still that I have just sort of been leaving them as is until a big cleanup can be done but it doesn't worry me to do it now :)

@IngCr3at1on
Copy link
Contributor

That's the check I was talking about :P

No, variable and function names are fine it's the actual defined value that concerns me.

@MitchellCash
Copy link
Contributor Author

@IngCr3at1on it was to, thank you!

Alright changed the defined value to PaycoinURI and rebased over master.

@MitchellCash
Copy link
Contributor Author

Rebased over master (plus I wanted Travis to run his eyes over it ;) )

@ligerzero459
Copy link
Contributor

Just tested this on Windows and ran into two issues. First, if Paycoin hadn't started yet, it started it properly, but then dumped at the Overview tab and the address from the URI isn't anywhere to be found. But if the wallet was already open, it attempted to start a new instance instead of using the one already launched.

@MitchellCash
Copy link
Contributor Author

@ligerzero459 damn I thought I had squashed those bugs. Are using gitian to build the Windows executables?

@IngCr3at1on
Copy link
Contributor

@MitchellCash yes that was compiled in gitian he used your branch specifically.

@MitchellCash
Copy link
Contributor Author

Thanks. So when I build in mingw I got it working but then gitian keeps having the issue described above which I was also facing on gitian builds. I will need to investigate further but if any of you doing gitian builds could also assist it would be much appreciated.

@IngCr3at1on
Copy link
Contributor

I'm just trying to figure out what the major difference would be.

@MitchellCash
Copy link
Contributor Author

@IngCr3at1on sorry stop that investigation I got confused. So it was a gitian build I used and I'm testing it again right now and it works.

I'm using a 32-bit install though. @ligerzero459 what about you?

@ligerzero459
Copy link
Contributor

@MitchellCash So this is working. Turns out it didn't re-create my shortcut when I installed it, so I started the 0.3.3.0 version instead of the 0.3.3.1c version. When I clicked the URI, it tried to open the new version, which I thought was already open. I started the right version and it detected the paycoin URIs like a boss

@IngCr3at1on
Copy link
Contributor

That's cool. I'm sure a lot of people would like this feature.

@MitchellCash
Copy link
Contributor Author

Good stuff! Thanks for testing

@MitchellCash
Copy link
Contributor Author

Just updated with some minor nits. No code changes. The three changes were:
ad0ef40
0f9c6a7
0626d6a

scroogemcdev added a commit that referenced this pull request Feb 16, 2016
Add support for opening paycoin: URIs directly.
@scroogemcdev scroogemcdev merged commit 6f5e188 into PaycoinFoundation:master Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants