Permalink
Browse files

Rename HTTP IsValidStart tests to be more descriptive

The names of those tests now follow a schema that should be more in line with the other tests in Pcap.Net.
  • Loading branch information...
FlorianHockmann committed Jan 27, 2017
1 parent cf6c718 commit e9071e5058a4a8f0ce52ba0c12c0aeb170900e69
Showing with 10 additions and 10 deletions.
  1. +10 −10 PcapDotNet/src/PcapDotNet.Packets.Test/HttpTests.cs
@@ -472,79 +472,79 @@ public void HttpRequestMethodBadKnownTest()
}
[TestMethod]
public void HttpMinimalValidRequestTest()
public void HttpIsValidStartRequestValidTest()
{
var packet = BuildPacket("UnknownMethod / HTTP/1.0\r\n\r\n");
Assert.IsTrue(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpRequestEmptyRequestUriNotAllowed()
public void HttpIsValidStartRequestWithMissingUriNotAllowedTest()
{
var packet = BuildPacket("GET HTTP/1.1\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpRequestMissingVersionNumberNotAllowed()
public void HttpIsValidStartRequestWithMissingVersionNumberNotAllowedTest()
{
var packet = BuildPacket("GET / HTTP/\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpRequestMissingVersionNotAllowed()
public void HttpIsValidStartRequestWithMissingVersionNotAllowedTest()
{
var packet = BuildPacket("GET /\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpRequestMissingMethodNotAllowed()
public void HttpIsValidStartRequestWithMissingMethodNotAllowedTest()
{
var packet = BuildPacket(" / HTTP/1.0\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpValidResponseTest()
public void HttpIsValidStartResponseValidTest()
{
var packet = BuildPacket("HTTP/1.0 200 OK\r\n\r\n");
Assert.IsTrue(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpMinimalResponseTest()
public void HttpIsValidStartResponseMinimalValidTest()
{
var packet = BuildPacket("HTTP/1.0 200 \r\n\r\n");
Assert.IsTrue(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpResponseMissingVersionNumberNotAllowed()
public void HttpIsValidStartResponseWithMissingVersionNumberNotAllowedTest()
{
var packet = BuildPacket("HTTP/ 200 OK\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpResponseMissingVersionNotAllowed()
public void HttpIsValidStartResponseWithMissingVersionNotAllowed()
{
var packet = BuildPacket(" 200 OK\r\n\r\n");
Assert.IsFalse(packet.Ethernet.IpV4.Tcp.Http.IsValidStart);
}
[TestMethod]
public void HttpResponseMissingStatusCodeNotAllowed()
public void HttpIsValidStartResponseWithMissingStatusCodeNotAllowedTest()
{
var packet = BuildPacket("HTTP/1.0 OK \r\n\r\n");

0 comments on commit e9071e5

Please sign in to comment.