Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

XadesDateTime#60

Merged
microshine merged 5 commits into
PeculiarVentures:masterfrom
brainbeanapps:xades_date_time
Nov 29, 2017
Merged

XadesDateTime#60
microshine merged 5 commits into
PeculiarVentures:masterfrom
brainbeanapps:xades_date_time

Conversation

@alexey-pelykh
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/xml/date_time.ts Outdated
* Check [dateformat]{@link https://www.npmjs.com/package/dateformat} for supported formatting options.
* If not specified, [Date#toISOString()]{@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString} is used.
*/
public Format: string;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks Format is optional

public Format?: string;

@microshine
Copy link
Copy Markdown
Contributor

@alexey-pelykh Could you update index.d.ts? It can be a reason of bad circleci test

@microshine microshine merged commit 28dddfa into PeculiarVentures:master Nov 29, 2017
@alexey-pelykh alexey-pelykh deleted the xades_date_time branch November 29, 2017 10:35
@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

Well, it still fails, unfortunately

@microshine
Copy link
Copy Markdown
Contributor

this is circleci setting. I can't to send coverall result to server. But mocha tests are ok

@microshine
Copy link
Copy Markdown
Contributor

v2.0.10 is available

@microshine
Copy link
Copy Markdown
Contributor

microshine commented Nov 29, 2017

@alexey-pelykh Thank you for your PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants