Support parent namespaces#17
Merged
microshine merged 5 commits intoNov 23, 2017
Merged
Conversation
microshine
reviewed
Nov 23, 2017
| if (found) { | ||
| let el = found.cloneNode(true) as Element; | ||
| this.FixupNamespaceNodes(doc as Element, el, true); | ||
| this.CopyNamespaces(el, el, true); |
Collaborator
There was a problem hiding this comment.
@alexey-pelykh I updated this line to
this.CopyNamespaces(found, el, true);I've got asic namespace on verifying
<xades:SignedProperties xmlns:asic="http://uri.etsi.org/02918/v1.2.1#" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:xades="http://uri.etsi.org/01903/v1.3.2#" Id="xades-id-a46287b499d8">Could you try to update and test signing again?
Contributor
Author
There was a problem hiding this comment.
That would work, done
microshine
reviewed
Nov 23, 2017
| return namespaces | ||
| } | ||
|
|
||
| protected CopyNamespaces(src: Element, dst: Element, ignoreDefault: boolean): void { |
alexey-pelykh
commented
Nov 23, 2017
alexey-pelykh
left a comment
alexey-pelykh
left a comment
Contributor
Author
There was a problem hiding this comment.
@microshine added comments and adjusted code
| if (found) { | ||
| let el = found.cloneNode(true) as Element; | ||
| this.FixupNamespaceNodes(doc as Element, el, true); | ||
| this.CopyNamespaces(el, el, true); |
Contributor
Author
There was a problem hiding this comment.
That would work, done
microshine
approved these changes
Nov 23, 2017
microshine
left a comment
microshine
left a comment
Collaborator
There was a problem hiding this comment.
It looks ok. There are some TS issues, I'll fix them by myself
@alexey-pelykh thank you for xmldsigjs improvement
Contributor
Author
|
Thanks for prompt approval! Sorry for TS-related issues |
Collaborator
|
I published new version v2.0.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.