Handle missing modules #9
Conversation
Not everyone using X Windows uses GTK (nor wants it). To help support these people, protect the call to 'require "abstk.AbsGtk"' to allow it to fail without aborting the program. Do the same with those that want to use GTK, but don't want to bother with the Curses interface, just to be consistent.
Modify the code to run under Lua 5.1 and 5.2. This is mostly just stubbing out utf8.len() with string.len(). This is probably a gross hack (and I'll understand it being rejected) but at the very least, it'll get someone up and running until a better utf8.len() for Lua 5.1/5.2 can be found or written.
There was a problem hiding this comment.
On c1a8fd7:
Yeah, I think that's a nice improvement. However, I'd ask you to put it this way:
do
local has_gtk, gtk_module = pcall(require,'abstk.AbsGtk')
local has_curses, curses_module = pcall(require,'abstk.AbsCurses')
if has_gtk then AbsGtk = gtk_module end
if has_curses then AbsCurses = curses_module end
end(If there's a better of requesting these kind of changes, forgive me and tell me. I'm not much into Github pull requesting stuff)
There was a problem hiding this comment.
On 1d1a1b9:
And I don't this would work for supporting older versions, because of the reason why I chose utf8.len() instead of string.len().
As you may know, Curses UI is based on characters. So, to align things properly, I must calculate everything around it based on its size. However, using string.len(), any character that isn't present on the ASCII table has its length miscalculated.
Even if it seems to support older Lua versions, it brings inconsistencies and, possibly, some other troubles (like things disappearing because they didn't fit). And I don't see any good reason to still using Lua 5.1 or 5.2. If you can show me a few, I'd be glad to find a better way to fix this (maybe adding another dependency to those cases?). Thanks for the request, though.
|
I haven't done much (if any) in the way of github push requests, so I'm not sure how to revert and make the changes for the module loading. It might be best for you to make the changes as you see fit---I don't mind (as it was a change I had to do to play around with it) (also, I can make the change and do another push request if you prefer). For the utf8 thing, I understand, but people using LuaJIT will be unable to use this module (since it's mostly Lua 5.1 with some 5.2 features). I didn't look to see if there were any utf8 modules for Lua 5.1/5.2 that can do length calculation (I'm still using Lua 5.1 because work is using it and there's been little reason to upgrade). |
|
I support the this pull request, same problem here. I am still using Lua 5.1 and Luajit(which only supports version 5.1). The fix might not be perfect for non-ascii string length, but it is good enough in most cases. |
|
OH, RIGHT! I totally forgot LuaJIT wasn't in Lua 5.3. If that's OK, I'll be glad in merging and updating the docs ;) |
|
The changes look good to me. |
|
Well, I think @javatmn won't oppose to it. Gonna merge right now. |
Not everyone using X Windows uses GTK (nor wants it). To help support these
people, protect the call to 'require "abstk.AbsGtk"' to allow it to fail
without aborting the program.
Do the same with those that want to use GTK, but don't want to bother with
the Curses interface, just to be consistent.
Also involved are changes to support this module under Lua 5.1/5.2. It's hack as it uses string.len() for utf8.len() but at least it will run (sigh---github failure here to separate these two changes)