Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Set hostname, set first user and set root password. #8

Closed
PedroHLC opened this issue Oct 8, 2019 · 5 comments · Fixed by #11

Comments

@PedroHLC
Copy link
Owner

commented Oct 8, 2019

A new screen is required where the user can insert a valid hostname to the new machine, the first user's username, the first user's password, and the root's password.

A double field with matching assertion is desired, but not required. Passwords shouldn't echo. It's recommended to use TextFields and present the input in at least three separate rows.

t's not necessary to create the user, set the password or set/write the hostname, as that will be appended to the setup script so the user can review it on later steps. So only keeping each field in memory is enough.

For layout/design inspirations, one can consult other screens, especially WifiMenu.

Estimated complexity: 100 lines of C code + 130 lines of QML.

Files that may be created:

  • src/lib/users.hpp
  • src/lib/users.cpp
  • qml/UserSetup.qml

Files that have to be modified:

  • src/main.cpp: Add include, instantiate new class, connect to a QML property.
  • qml/MainContainer.qml: Needs to instantiate the new component and assign an id to it.
  • chaotic-installer.pro Add new cpp and hpp to the build system.
@PedroHLC PedroHLC referenced this issue Oct 8, 2019
10 of 21 tasks complete
@vagnervst

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Hi @PedroHLC, I noticed there is a gitignore for Makefile, which probably prevented it from being pushed:

Is it possible to contribute without it?

@PedroHLC

This comment has been minimized.

Copy link
Owner Author

commented Oct 9, 2019

Hi @vagnervst, Makefile is actually generated when running qmake -project .... So there's no need for sharing it 😄

@vagnervst

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@PedroHLC That's odd, it wasn't generated here 🤔 Any idea of what might it be?

@vagnervst

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@PedroHLC I got it working! I had to run qmake -o Makefile ... as well, this way the Makefile was generated successfully 🙂

I'll try to solve the issue tonight, thanks for your help!

@vagnervst vagnervst referenced this issue Oct 13, 2019
5 of 5 tasks complete
@vagnervst

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2019

@PedroHLC Opened the PR! Drop a review there when possible 😄

@PedroHLC PedroHLC closed this in #11 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.