Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language select view #3

Merged
merged 7 commits into from Oct 1, 2019

Conversation

@PedroHLC
Copy link
Owner

commented Oct 1, 2019

This change is Reviewable

@PedroHLC PedroHLC changed the title [WIP] Add language select view Add language select view Oct 1, 2019
Copy link
Owner Author

left a comment

Reviewed 14 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion


src/lib/language.cpp, line 13 at r1 (raw file):

void Lang::setLang(QString locale) {
	QString path =
		QStringLiteral("langs/%2.qm")

Should be %1

@PedroHLC PedroHLC force-pushed the set-lang branch from 92fb501 to 1550d3e Oct 1, 2019
Copy link
Owner Author

left a comment

:lgtm:

Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @PedroHLC)

@PedroHLC PedroHLC merged commit e334bd3 into master Oct 1, 2019
@PedroHLC PedroHLC referenced this pull request Oct 1, 2019
10 of 21 tasks complete
@PedroHLC PedroHLC deleted the set-lang branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.