Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard select view #4

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@PedroHLC
Copy link
Owner

commented Oct 2, 2019

Still following #1


This change is Reviewable

@PedroHLC PedroHLC force-pushed the set-keys branch from 02a0e74 to c0cce2a Oct 2, 2019
@PedroHLC PedroHLC changed the title [WIP] Add keyboard select view Add keyboard select view Oct 2, 2019
Copy link
Owner Author

left a comment

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion


chaotic-installer.pro, line 8 at r1 (raw file):

VPATH *= $${BASEDIR}/src

TRANSLATIONS = langs/en_US.ts langs/pt_BR.ts

I believe you sir forgot to update translations!

Copy link
Owner Author

left a comment

Reviewed 1 of 2 files at r2.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion


langs/pt_BR.ts, line 10 at r2 (raw file):

If unsure leave default</source>
        <translation>Selecione o seu layout de teclado:\n\nCaso não tenha certeza, deixe o padrão</translation>

nope, you did it wrong!

@PedroHLC PedroHLC force-pushed the set-keys branch from aaa25a9 to e71ac17 Oct 2, 2019
Copy link
Owner Author

left a comment

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PedroHLC PedroHLC merged commit 049e094 into master Oct 2, 2019
@PedroHLC PedroHLC deleted the set-keys branch Oct 2, 2019
@PedroHLC PedroHLC referenced this pull request Oct 2, 2019
10 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.